Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 154573

Summary:	The FacesServlet class name is hardcoded to javax.faces.webapp.FacesServlet
Product:	[WebTools] Java Server Faces	Reporter:	Eric Norman <Eric.Norman>
Component:	Core	Assignee:	Gerry Kessler <gerry.kessler>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	gerry.kessler
Version:	1.5	Keywords:	helpwanted
Target Milestone:	2.0 M6
Hardware:	All
OS:	All
Whiteboard:

Description Eric Norman

2006-08-21 13:15:04 EDT

When creating a new web project with the JSF facet, the FacesServlet servlet is declared in the web.xml using the hardcoded classname 'javax.faces.webapp.FacesServlet'.  (see JSFFacetInstallDelegate class)

However, our JSF implementation uses a custom servlet with a different classname, so the web.xml must be manually edited to change the servlet class name for each new project.

It seems like the FacesServlet servlet-class needs to be declared when creating the implementation 'JSF Library'.  Then the JSF install delegate should get the FacesServlet servlet-class from the selected implementation JSF library.

Comment 1 Gerry Kessler

2006-08-21 16:07:54 EDT

Eric,

Would you characterize this as a blocker?   Is your severity set high enough?

To fix this I propose that meta-data be added to an JSF implementation libary that is used when setting the web.xml entry at facet installation time.

Unfortunately this would be considered an API change that would make it difficult to get into 1.5.1.  That sort of thing is highly discouraged in a maintenance release.

I see from 154573 that you may have other requirements that are related to JSF facet installation and JSF Libs.   If you like, please create a bugzilla entry that lists all of the enhancements that you would like to see.  The JSF Tools team is in the process of gathering requirements for the next major release and would love to hear and consider all of the suggestions that you may have.  

Regards,
Gerry Kessler

Comment 2 Eric Norman

2006-08-22 19:42:43 EDT

Well, we are able to workaround the problem, so it is technically not currently blocking us. We have a custom facet that is adding some extra configuration and we are able to programmatically update the servlet-class in there.  Would prefer to get rid of that hack eventually though.

As you suggested, I will file another bugzilla in the next few days with some other suggestions/nitpicks that I have run accross.  

Thanks,
Eric

Comment 3 Raghunathan Srinivasan

2007-01-05 17:52:28 EST

Triaged for WTP 2.0

Comment 4 Gerry Kessler

2007-04-02 13:18:07 EDT

fixed for M6 build