Bug 150504

Description David Slubicki 2006-07-13 09:29:25 EDT

Some of the "get*Model*" methods perform unnecessary work if a model already exists.  

Example:
The following three (abbreviated) methods provide one path to acquiring a model:


public synchronized IStructuredModel getModelForEdit(IFile iFile){
     return _commonGetModel(iFile, EDIT, null, null);
}


private IStructuredModel _commonGetModel(IFile iFile, ReadEditType rwType, String encoding, String lineDelimiter)
     { 
	String id = calculateId(iFile);
	IModelHandler handler = calculateType(iFile);
	URIResolver resolver = calculateURIResolver(iFile);
	IStructuredModel model = _commonGetModel(iFile, id, handler, resolver,   rwType, encoding, lineDelimiter);
	return model;
     }


private IStructuredModel _commonGetModel(IFile file, String id, IModelHandler handler, URIResolver resolver, ReadEditType rwType, String encoding, String lineDelimiter) 
     {
	IStructuredModel model = null;
	if (file != null && file.exists()) {
             SharedObject sharedObject = (SharedObject) fManagedObjects.get(id);
	     if (sharedObject == null) {
		// model created here
	     } else {
		_incrCount(sharedObject, rwType);
	     }
	     model= (model!= null)? model = sharedObject.theSharedModel : null;
	}
	return model;
     }


Notice the unnecessary calculations being done in the second method.  These calculations should only be performed if a model doesn't already exist in the cache, as the computed values are never used otherwise.

The call to: "calculateType(iFile);" appears to be expensive sometimes, so it would be nice to avoid it if possible.