Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 150381

Summary:

Edit repository properties wizard don't save custom properties

Product:

z_Archived

Reporter:

Eugene Kuleshov <ekuleshov>

Component:

Mylyn

Assignee:

Robert Elves <robert.elves>

Status:

RESOLVED FIXED

QA Contact:

Severity:

blocker

Priority:

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
mylar/context/zip	none

Description Eugene Kuleshov

2006-07-12 09:17:45 EDT

It is easily reproduceable with web repository connector. None of the custom settings are saved

Comment 1 Mik Kersten

2006-07-14 21:12:29 EDT

I vaguely recall fixing this, is it still happening?

Comment 2 Eugene Kuleshov

2006-07-14 22:06:22 EDT

(In reply to comment #1)
> I vaguely recall fixing this, is it still happening?

Yes. Problem is still there. I've commented on some other bug while ago about it and mentioned that Rob, boke it on some of his refactorings.

Comment 3 Robert Elves

2006-07-19 14:03:19 EDT

Fixed. Overide AbstractRepositorySettingsPage.updateProperties(TaskRepository repository) to update custom properties.

Comment 4 Robert Elves

2006-07-19 14:04:12 EDT

Created attachment 46523 [details]
mylar/context/zip

repository custom property update on edit

Comment 5 Eugene Kuleshov

2006-07-19 14:09:42 EDT

(In reply to comment #3)
> Fixed. Overide AbstractRepositorySettingsPage.updateProperties(TaskRepository
> repository) to update custom properties.

Should AbstractRepositorySettingsPage.createTaskRepository() delegate to updateProperties() method? So, it won't be necessary to owerride it in WebRepositorySettingsPage class...

Comment 6 Robert Elves

2006-07-19 14:20:48 EDT

Thanks, that cleans things up even more. Done.