Bugzilla – Full Text Bug Listing
| Summary: | [build path] allow selecting a working set for new Java project | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Victor Toni <victor.toni> | ||||||||||
| Component: | UI | Assignee: | Benno Baumgartner <benno.baumgartner> | ||||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | bpasero, gabriele.garuglieri, j.verschoor, markus.kell.r, martinae | ||||||||||
| Version: | 3.3 | ||||||||||||
| Target Milestone: | 3.3 M7 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows XP | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Victor Toni
I see, but creating a project is not really related to what the package explorer is drilled in (go into). But we could add configuration to the new Java project wizard to choose a working set (first page, checkbox: add new project to working set, combo: all working sets) But it should. A working set should be treated as a resource as it used as context in other use cases (e.g. it can be the "parent" of the multiple projects in regard to the problem view). If one uses working sets the new project will be definitely be part of a working set being it only the "Other projects" fallback. Preselecting the current working set (in the checkbox) would be a nice solution. *** Bug 154590 has been marked as a duplicate of this bug. *** (In reply to comment #3) > If one uses working sets the new project will be definitely be part of a > working set being it only the "Other projects" fallback. > > Preselecting the current working set (in the checkbox) would be a nice > solution. > Yes, that would be great, if new projects came by default into the current working set. It is kind of awkward if you are in a working set, create a new project and don't see the project afterwards. Changed target to 3.3. M7 new project wizard polish Created attachment 63899 [details]
fix
fixed > I20070410-1043 Uhfff, this may need a iteration or two... Please give it a try and give feedback, thanks. My comments: - The UI needs a checkbox: 'Add new project to the following working sets:' - It would be nice if the input field would be a combo that shows the previously used sets of working sets - The selection dialog description should: 'The new project will be added to the following working sets:' Reopening, since the support was taken out for the I-build. See also bug 15941 and its dups for the general request in Platform/UI. A problem in HEAD is also that IWorkingSet.adaptElements(IAdaptable[]) is not called before adding stuff to existing working sets in JavaProjectWizard.performFinish(). The wizard should also get its default working set(s) from the Package Explorer if the selection is empty and the Package Explorer was the active view. There are two cases: a) Package Explorer with 'Top Level Elements > Projects' and a working set enabled as filter => Should default to the filter working set. b) Package Explorer with 'Top Level Elements > Working Sets' and 'context menu > Go Into' a working set was applied => Should default to the context working set. The Window Working Set is a difficult problem, since you cannot add anything to it. An approach could be to add the new project to all working sets in the window working set. Another possibility could be to ask the user if filters should be removed to reveal the project (but only if the Package Explorer was active!). Created attachment 64028 [details] fix 10 Implements everything requested by comment #10 Created attachment 64151 [details] fix 12 Implements everything requested by comment #12. Unfortunately the reveal dialog is shown on top of the new project wizard which does look a bit odd. But I don't know any way around it... JavaProjectWizard#performFinish() should still call selectAndReveal(..), even if the PE was not the active view, otherwise the element will not be selected in other views. I guess you should try to call tryToReveal(..) in an asyncExec, so that it is only executed after the dialog has been closed. I couldn't get comment 12 to work in HEAD with an *empty* selection. The working set selection dialog should be resizable, and it should not have a help icon. Created attachment 64177 [details]
fix 15-17
Forgot the empty selection. async exec works good. Thanks Markus!
fixed? > I20070417-0800 Hint that the org.eclipse.jdt.internal.ui.workingsets.WorkingSetConfigurationBlock is java agnostic and could be used in other new wizards. Verified in I20070502-0010. *** Bug 85369 has been marked as a duplicate of this bug. *** |