Bugzilla – Full Text Bug Listing
| Summary: | Request repository credentials when they aren't set for repository | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Eugene Kuleshov <ekuleshov> |
| Component: | Mylyn | Assignee: | Robert Elves <robert.elves> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P2 | CC: | listas, wmitsuda |
| Version: | unspecified | ||
| Target Milestone: | 2.0 M2 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 152212, 174864, 175064 | ||
|
Description
Eugene Kuleshov
*** Bug 168672 has been marked as a duplicate of this bug. *** Please also note that "anonymous" checkbox should NOT be derived from the user name and should be an explicitly saved separate property. Yes, it is very confusing how the repositories flip into anonymous mode. (In reply to comment #3) > Yes, it is very confusing how the repositories flip into anonymous mode. It is not just confusing, but preventing to implement this logic to show the credential dialog if it is not an explicitly anonymous account. Fixed. Added TaskRepository.isAnonymous() and TaskRepository.setAnonymous(boolean). Checks for missing credentials upon startup and import of task list / repository data. Is this already fixed? I'm using 3.3 I20070410-1043 + Mylar 2.0.0.v20070405-1130 and I just got in a situation where trying to submit a task make it popup a message box instructing me to go to repositories dialog (the credentials were blank) and set the credentials. Was the purpose of this bug to show the credentials dialog or just preventing it from getting into the anonymous state? Checking was implemented so that if credentials were lost due to upgrade the credentials would be requested upon workbench startup. The Task Repository credentials page shouldn't allow to complete if not anonymous and no credentials provided (bug#18033). (In reply to comment #7) > Checking was implemented so that if credentials were lost due to upgrade the > credentials would be requested upon workbench startup. > Strange, I don't remember having been asked for credentials on startup. Note that actually I'm upgrading to I-builds and Mylar dev-builds on a weekly frequency, always over the same tasklist. This was tested this morning but perhaps we're missing some edge case here. Re-opening until we can confirm. Rob, how it supposed to work? I am pretty sure it does not work for JIRA and I also don't recall being asked for Bugzilla credentials. (In reply to comment #10) > Rob, how it supposed to work? I am pretty sure it does not work for JIRA and I > also don't recall being asked for Bugzilla credentials. Have a look at checkForCredentials() in TasksUiPlugin. It's being called from an asyncExec within the plugin's start method. I just noticed it working on startup after clearing my credentials. But I find it weird that the dialog shows before the workbench launches. So I'm wondering if it should work like CVS and check on every synch or on first synch. (In reply to comment #12) > But I find > it weird that the dialog shows before the workbench launches. So I'm wondering > if it should work like CVS and check on every synch or on first synch. > +1. I think it should ask the credentials every time it tries to do some operation and it fails to authenticate due to invalid credentials, i.e. the fail triggers the dialog, like on CVS. Note: it worked on my home machine after updating from 2.0.0.v20070420-0030 to 2.0.0.v20070421-0200. But I still don't remember having been asked after updating to 2.0.0.v20070420-0030. There was a bug in previous builds and is now fixed but we should still investigate making this work like CVS. Funny. It is now asking for these credentials for web repository connector... (In reply to comment #16) > Funny. It is now asking for these credentials for web repository connector... Fix committed to the head. Marking fixed as Task Repository settings page is displayed when submission via task editor (or attachments) fails due to login error. All other cases should be revealed as warning in task list as usual. I find the prompt for missing credentials after start-up rather annoying. I have repositories that I don't use frequently and I do not want to enter the credentials for all those repositories after each Eclipse update or -clean run. It would also be nice not be forced to store credentials but make this optional as CVS does it. Rob, since this seems partly done already, how difficult would it be to show the repository configuration dialog when the first user initiated repository operation fails? (In reply to comment #19) > Rob, since this seems partly done already, how difficult would it be to show the > repository configuration dialog when the first user initiated repository > operation fails? I've added this for both posting attachments and submitting from task editor. I think we also need to cover search and manual synchronization. Updating attributes could use this as well. This seems like a perfect case for aspects. |