Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 148362

Summary: DisplayView registers Ctrl+Space globally
Product: [Eclipse Project] JDT Reporter: Markus Keller <markus.kell.r>
Component: DebugAssignee: Michael Rennie <Michael_Rennie>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: cocoakevin
Version: 3.2   
Target Milestone: 3.3 M1   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Markus Keller CLA 2006-06-23 05:43:11 EDT
I20060620-1010

The DisplayView registers Ctrl+Space globally. As soon as the DisplayView is created, Ctrl+Space stops working in e.g. the Package Explorer.

The problem has been introduced with the fix for bug 146648 in DisplayView.java:
The old code in createActions() was:
    new HandlerSubmission(null, null, getSite(),..)

The site has been lost in the new code:
    Workbench workbench = PlatformUI.getWorkbench();
    IHandlerService handlerService = (IHandlerService) workbench.getAdapter(IHandlerService.class);

I think the handler service should be retrieved like this:
    IHandlerService handlerService = (IHandlerService) getSite().getService(IHandlerService.class);

I'll file a bug for Platform/UI for their mediocre documentation.
Comment 1 Kevin Barnes CLA 2006-06-23 08:43:00 EDT
Mike please verify
Comment 2 Michael Rennie CLA 2006-06-24 12:35:26 EDT
verified