| Summary: | NotDefinedException when opening Log Interactions view | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Peter Kim <petekim> | ||||||
| Component: | TPTP | Assignee: | Yasuhisa Gotoh <gotohy> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | major | ||||||||
| Priority: | P1 | CC: | apnan, jkubasta, labadie, prafulr, ruthdaly, zung | ||||||
| Version: | unspecified | Keywords: | plan | ||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | closed460 | ||||||||
| Attachments: |
|
||||||||
|
Description
Peter Kim
Created attachment 45106 [details]
ScenarioOne lgs
not critical for 4.2.1; moving to 4.3 *** Bug 155446 has been marked as a duplicate of this bug. *** Moving to 4.4. This defect requires investigation, I'll set for now an 8h estimate. This is required from AC perspective. Targetting 4.5 i2. Changing target to 4.5 i4. The scopeId "org.eclipse.ui.globalScope" used for the accelerator set has been deprecated. Need to use "org.eclipse.ui.contexts.window" instead. Also this context ID can be referred as IContextIds#CONTEXT_ID_WINDOW. Created attachment 83225 [details]
Patch file
Patch created. Please review.
Yhe fix works weel but we still use the old keybinding mechanism. Is it possible to get rid of the deprecated call site.getSite().getKeyBindingService().setScopes(sdScopes); ? The current patch code appears to be working expectedly and we need further investigation for removing the deprecated calls without breaking the compatibility. As discussed in the call, I have opened a follow-on bug 210495 for the activity. Alex, I have noticed that this fix should be applied to the platform project and I do not have permission. Could you please check in the patch for me? Fix checked in. *** Bug 199088 has been marked as a duplicate of this bug. *** As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |