Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 148259

Summary: [Ruler] Rulers draw focus when first shown
Product: [Tools] GEF Reporter: Pratik Shah <ppshah>
Component: GEF-Legacy GEF (MVC)Assignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: nyssen
Version: 3.2   
Target Milestone: 3.7.1 (Indigo) M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Pratik Shah CLA 2006-06-22 13:43:11 EDT
Both rulers show focus when made visible, even if they don't have it.  I was able to reproduce this in the GEF logic example.
Comment 1 Alexander Nyßen CLA 2011-04-07 12:58:34 EDT
Besides showing focus when not having it, rulers as well as guides also show focus to indicate they are selected. That is inconsistent w.r.t. how selection is handled in the primary viewer (compare bug #332341).
Comment 2 Alexander Nyßen CLA 2011-04-07 16:25:09 EDT
The general refactoring of how to properly handle focus and selection should be addressed within bug #332341. Here, I will just fix that the RulerEditPart does not get focus unless the RulerViewer has focus.
Comment 3 Alexander Nyßen CLA 2011-04-07 16:41:52 EDT
Changed that RulerViewer's contents edit part becomes the focus part only in case the RulerViewer gains focus and no other focus part was set, not when being set as contents to the viewer; ensure it is unset in case the viewer looses focus.

Changes committed to cvs HEAD (3.7M7). Resolving as fixed.