Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 147181

Summary:	[implementation] Incorrect use of instanceof TextSelection
Product:	[Eclipse Project] Platform	Reporter:	David Williams <david_williams>
Component:	Text	Assignee:	Platform-Text-Inbox <platform-text-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.2
Target Milestone:	3.3 M1
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:
Bug Blocks:	134047

Description David Williams

2006-06-14 21:11:02 EDT

In AbstractTextEditor, selectAndReveal is an if conditional that uses

(selection instanceof TextSelection)

I'm pretty sure you mean 
selection instanceof ITextSelection 

I discovered this while investigating bug 134047 
which might have involved implementing ITextSelection with something other than
TextSelection, 
and I was just seeing if any one mistakenly used 
cast or intanceof TextSelection :)

Comment 1 Dani Megert

2006-06-15 03:35:48 EDT

Thanks David - good catch!
Do you need this in 3.2.1 or is 3.3 good enough?

Fixed in HEAD.

Comment 2 David Williams

2006-06-15 03:57:58 EDT

3.3 is fine ... we can "fake it" until then. 

Thanks.