Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 147180

Summary:	Incorrect use of instanceof TextSelection
Product:	[WebTools] Java Server Faces	Reporter:	David Williams <david_williams>
Component:	UI	Assignee:	Jean Choi <jchoi>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	raghunathan.srinivasan
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description David Williams

2006-06-14 21:05:21 EDT

at line 114 of GeneralViewSectionDescriptor.java there is a boolean condition that uses

selection instanceof TextSelection 

I'm pretty sure you mean 
selection instanceof ITextSelection 

I discovered this while investigating bug 134047 
which may involve implementing ITextSelection with something other than TextSelection, 
and I was just seeing if any one mistakenly used 
cast or intanceof TextSelection :)

Comment 1 David Williams

2006-06-14 21:11:54 EDT

and don't feel bad, see bug 147181 :)

Comment 2 Raghunathan Srinivasan

2006-06-15 13:36:14 EDT

Please review.

Comment 3 Jean Choi

2006-06-16 03:43:31 EDT

Fixed, change TextSelection to its interface.

Comment 4 John Lanuti

2007-04-03 11:48:19 EDT

Closing as part of mass query to clean up old resolved bugs in untargetted milestones.