Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 146539

Summary: tptp:execution Ant task puts invalid paths into resultsrefid attribute (not resolving project root folders correctly)
Product: z_Archived Reporter: John O'Shea <john.oshea>
Component: TPTPAssignee: Joe Toomey <jptoomey>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: paulslau, ravi.aroy, scott.schneider
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
mylar/context/zip none

Description John O'Shea CLA 2006-06-12 06:46:37 EDT
It appears that the <tptp:execution> Ant task assumes that TPTP project folders are always physically located under the workspace directory.  When I run this task like

		<tptp:execution resultsrefid="tptp.test.results"
		    project="${tptp.test.project}" 
		    suite="testsuites/SampleTest.testsuite"
		    deployment="testsuites/AutoUiDeployment.deploy">
		</tptp:execution>
	</target>

I subsequently pass the tptp.test.results refid into the test-results-interrogation task to see what happened:

	<!-- Interrogate test suite results for verdict -->
	<target name="test-results-interrogation">
		<echo message="Interrogating test suite results..." />
		<condition property="tptp.test.success">
			<tptp:interrogation verdictproperty="tptp.test.verdict">
			    <filelist refid="tptp.test.results"/>
			</tptp:interrogation>
		</condition>
		<echo message="The overall test result verdict is: '${tptp.test.verdict}'" />
	</target>

If the project that I am testing is not located beheath the workspace folder then I get the following error:

test-results-interrogation:
     [echo] Interrogating test suite results...
     [echo] Results File is: 'org.apache.tools.ant.types.FileList@1c282a1'
[condition] C:\fdb2\test\ui-tests\workspace\com.capeclear.ui.test\SampleTest_1150107716328.execution does not exist -- s
kipping


It looks like the implementation is not resolving the project path's real root folder but rather is assuming that it is relative to the workspace root folder.

(I'm sure you are aware that it is a common scenario to import projects from locations outside the workspace dir).   

Hope I've logged this against the correct TPTP component?
Comment 1 Joe Toomey CLA 2006-07-31 11:05:56 EDT
Hi John,

This defect appears to have lain dormant for a while.  I will be taking ownership of the ASF code in TPTP, and can fix this defect.  However, we are about to begin our final test pass of the 4.2.1 release, and without a low-risk fix in hand, this defect is no longer a candidate to be fixed in this release.  We can address it in 4.3 i2 (which will open in a couple of weeks.)  Based on the defect severity, I assume this is okay with you.  If it is not, please reply and increase the severity of the defect, and we can discuss possible alternatives.

Thanks,
--Joe
Comment 2 John O'Shea CLA 2006-07-31 11:14:36 EDT
If 4.3i2 is coming in a couple of weeks we can wait until then. 

We do currently the workaround of creating the workspace in the folder below the project dir so this is not blocking.
Comment 3 Joe Toomey CLA 2006-07-31 11:28:00 EDT
4.3 is scheduled to GA at the end of October.  4.2.1 is scheduled to GA at the end of September, but we are beginning the shutdown process very early, and are now including only stop-ship fixes.

CVS HEAD will open for 4.3 i2 work (which will include 4.3 enhancements) on August 14th.  Daily development builds will be available as usual, but the first "stable driver" (on which we have completed a full test pass) will not be available until the end of i2 (September 22nd.)  Hopefully this will not dissuade you from taking and using a development driver to address this problem once the fix has been made.
Comment 4 Paul Slauenwhite CLA 2006-10-20 14:53:07 EDT
Please target to 4.4 since all non-blocking/critical defects will be deferred as decided in today's AG call.
Comment 5 Joe Toomey CLA 2006-11-02 08:38:24 EST
Unfortunately, I let this defect go too long, and I can no longer get approval to fix it in 4.3.  I will address it as soon as 4.4 opens.  Sorry for the delay.
Comment 6 Joe Toomey CLA 2007-01-25 10:51:53 EST
Created attachment 57515 [details]
mylar/context/zip

Incomplete fix, moving to new workspace
Comment 7 Joe Toomey CLA 2007-02-05 10:27:14 EST
Fix is still incomplete but ongoing.  Need to target for i2.
Comment 8 Joe Toomey CLA 2007-03-22 09:11:57 EDT
The priority of this defect has not changed, but it is being deferred to i3 to allow for other work with UI changes that need to be complete in i2.
Comment 9 Joe Toomey CLA 2007-05-03 11:00:25 EDT
Fix from March finally validated and delivered.  Sorry for the slow turnaround.
Comment 10 Paul Slauenwhite CLA 2007-06-02 14:52:10 EDT
Reporter: Please verify and close in preparation for shutting down the TPTP 4.4 release.  Thanks.
Comment 11 Joe Toomey CLA 2007-07-10 14:20:52 EDT
Fixed and validated in TPTP 4.4.  Closing.