Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 145842

Summary:

TVT3.2:TCT870: Wrong reading order of path/file names

Product:

[Eclipse Project] Platform

Reporter:

CDE Administration <cdeadmin>

Component:

Assignee:

Karice McIntyre <Karice_McIntyre>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

afarrag, camle, Karice_McIntyre, kitlo, Tod_Creasey

Version:

3.2

Target Milestone:

3.2.1

Hardware:

OS:

Linux-GTK

URL:

870

Whiteboard:

Bug Depends on:

Bug Blocks:

130587

Attachments:

Description	Flags
RTL_path_names.jpg	none
RTL_path_names_menu.jpg	none
RTL_path_names_properties_view.jpg	none
apply patch to workbench and ide	none
pic of mangled file names in MRU list	none
apply patch to org.eclipse.ui.workbench	none

Description CDE Administration

2006-06-07 15:10:45 EDT

Description:

In some places,  path/file names are still displayed RTL (most places were fixed in the last release). See examples in attached screen shots.
All areas where path/file names appear must be set with LTR reading order.

OS : Windows
Must Fix: YES
Blocking: NO
Build Date: 0604
Language: IW
Component:  Base
Tester: Gaby Pelleg:

This article was reassigned from Category:''TVT/Testing''.

Comment 1 CDE Administration

2006-06-07 15:10:57 EDT

Created attachment 43760 [details]
RTL_path_names.jpg

Comment 2 CDE Administration

2006-06-07 15:11:01 EDT

Created attachment 43761 [details]
RTL_path_names_menu.jpg

Comment 3 CDE Administration

2006-06-07 15:11:04 EDT

<cde:tctdetail>
Testcase: General
Project: WSW32
Component: CDE - Platform/UI
Priority: 2
Subject: Wrong reading order of path/file names
Article ID: 870
Originator: gpelleg@il.ibm.com
</cde:tctdetail>

Comment 4 Karice McIntyre

2006-06-07 15:32:15 EDT

Another instance of the problem reported in bug 119928.

Comment 5 CDE Administration

2006-06-09 13:06:02 EDT

Adding another screen shot with similar problem - properties view,

Comment 6 CDE Administration

2006-06-09 13:06:03 EDT

Created attachment 44011 [details]
RTL_path_names_properties_view.jpg

Comment 7 CDE Administration

2006-06-12 11:16:23 EDT

We need this bug fixed for 3.2.1. Thank you.

Comment 8 Karice McIntyre

2006-06-12 11:34:33 EDT

There are a lot of bugs that fall under the umbrella of bug 130587 - this is one of them.  To fix this one, the workbench label provider would have to be changed, which may be too big of a change for a maintenance release since this is a public class that is used by alot of other components.  Tod, what do you think?

Comment 9 Tod Creasey

2006-06-12 11:42:30 EDT

The WorkbenchLabelProvider is generic and does not differentiate if something is a file path or not

   IWorkbenchAdapter adapter = getAdapter(element);
        if (adapter == null) {
            return ""; //$NON-NLS-1$
        }
        String label = adapter.getLabel(element);

        //return the decorated label
        return decorateText(label, element);

As paths are going to be handled differently they need to be handled on a case by case basis.

Comment 10 Karice McIntyre

2006-06-12 12:06:41 EDT

*** Bug 133556 has been marked as a duplicate of this bug. ***

Comment 11 Karice McIntyre

2006-06-12 14:21:56 EDT

Created attachment 44167 [details]
apply patch to workbench and ide

This patch fixed the properties view, Navigator view, and File MRU menu entries.

Comment 12 Karice McIntyre

2006-06-12 16:59:47 EDT

Released fixes to both 3.2.1 and 3.3 streams for File MRU menu entries, property sheet, and workbench file adapter (used in Navigator).

Comment 13 Karice McIntyre

2006-06-19 10:51:52 EDT

*** Bug 142278 has been marked as a duplicate of this bug. ***

Comment 14 Karice McIntyre

2006-08-02 10:27:13 EDT

Due to bug 152035, the code in the label provider will have to be rolled out - the rest of the patch will stay though.

Comment 15 Karice McIntyre

2006-08-31 10:22:20 EDT

NOT verified for file MRU list in M20060830-0800.  The string gets completely mangled.

Comment 16 Karice McIntyre

2006-08-31 10:28:43 EDT

Verified for the property sheet.

Comment 17 Karice McIntyre

2006-08-31 10:33:27 EDT

Created attachment 49177 [details]
pic of mangled file names in MRU list

In the highlighted strings, the first close bracket should be an open bracket and the file extension and project name switched positions in the string!

Comment 18 Karice McIntyre

2006-08-31 11:23:00 EDT

Created attachment 49183 [details]
apply patch to org.eclipse.ui.workbench

patch to fix the problem.
Test case to check is PROJECT/FOLDER/FILE.EXT (all Hebrew characters).

Comment 19 Karice McIntyre

2006-09-05 17:43:47 EDT

released to 3.2.1 stream for tomorrow morning's build.
released to HEAD for build > 20060905, also with changes to get rid of warnings.