Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 145841

Summary: [internal api] Usage of org.eclipse.jdt.internal.core.util.Util
Product: [WebTools] WTP Java EE Tools Reporter: Konstantin Komissarchik <konstantin>
Component: jst.j2eeAssignee: Chuck Bridgham <cbridgha>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: major    
Priority: P3 CC: stryker
Version: 1.5Keywords: helpwanted
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Konstantin Komissarchik CLA 2006-06-07 15:07:43 EDT
It looks like we are relying on an internal JDT class to process filters. This pulls in JavaProject and ClasspathEntry, both internal. I am unclear as to what exactly this filter processing does, but if we really need it we should encapsulate it in a non-internal wtp class so that we make internal jdt references from one place instead of many places.

See org.eclipse.jst.common.jdt.internal.classpath.FlexibleProjectContainer for the usage of jdt.internal.core.util.Util class.
Comment 1 David Williams CLA 2006-08-29 23:11:15 EDT
Just changing subject "key word" to fit conventions. 

Chuck, can this be fixed in 151? 



Comment 2 David Williams CLA 2006-08-29 23:17:59 EDT
BTW, you mention "non-internal wtp class" ... but, non of our API should depend on another projects internals, if that what you meant. I agree, would be nice to have centralized, so its clearer what and where the dependancy is. I'm just recommending we not imply it is API. 

Comment 3 Konstantin Komissarchik CLA 2006-08-30 09:21:55 EDT
Ideally we eliminate the reliance on internal api. If it cannot be eliminated, we should at least consolidate its usage in a WTP utility class.
Comment 4 David Williams CLA 2006-08-31 23:54:52 EDT
Let's count all internal usage as "major" since it prevents the function of "easy safe binary compatible updates". (or, at least, reduces the probablity). 
Comment 5 Rob Stryker CLA 2010-04-02 03:48:45 EDT
The mentioned class currently seems to reference only public API from JDT