Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 145494

Summary: EllipseAnchor and FanRouter can't be used together
Product: [Tools] GEF Reporter: aimd liu <aimdlau>
Component: GEF-Legacy GEF (MVC)Assignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse, nyssen
Version: 3.2   
Target Milestone: 3.7.2 (Indigo SR2)   
Hardware: PC   
OS: Windows XP   
URL: http://aimd.cnblogs.com
Whiteboard:

Description aimd liu CLA 2006-06-06 05:08:53 EDT 
EllipseAnchor and FanRouter can't be used together, and other Anchors work well. may be EllipseAnchor has not override the equals method:(
Comment 1 Steven R. Shaw CLA 2006-06-07 09:21:31 EDT 
Workaround would be to extend EllipseAnchor and provide your own hashMap / equals implementations.
Comment 2 Alexander Nyßen CLA 2011-09-11 11:17:22 EDT 
Added equals() and hashCode() implementations to EllipseAnchor. Testes with a manually tweaked Shapes Example that FanRouter and EllipseAnchor now work well with each other. Committed changes to cvs HEAD and 3.7 maintenance branch.
Comment 3 Anthony Hunter CLA 2011-09-12 10:04:22 EDT 
Why are we moving this to 3.7.1 now? We are at RC3, this is too late for 3.7.1 no?
Comment 4 Alexander Nyßen CLA 2011-09-12 10:07:34 EDT 
Oops, I wasn't aware about this. There is no API-incompatible change related to this (I just implemented equals() and hashCode(), but I could revert this in 3.7.1 and only leave it in the HEAD branch.
Comment 5 Alexander Nyßen CLA 2011-09-12 10:11:35 EDT 
(In reply to comment #4)
> Oops, I wasn't aware about this. There is no API-incompatible change related to
> this (I just implemented equals() and hashCode(), but I could revert this in
> 3.7.1 and only leave it in the HEAD branch.

Or do we want to leave it in place? Your decision...
Comment 6 Anthony Hunter CLA 2011-09-12 10:18:07 EDT 
Actually we are past RC3, this change has to be removed from the maintenance stream.
Comment 7 Anthony Hunter CLA 2011-09-12 10:20:26 EDT 
Actually, just leave it, it will go in 3.7.2.
Comment 8 Alexander Nyßen CLA 2011-09-12 10:26:06 EDT 
(In reply to comment #7)
> Actually, just leave it, it will go in 3.7.2.

How that?
Comment 9 Anthony Hunter CLA 2011-09-12 10:34:55 EDT 
Our RC2 build is the final 3.7.1 build. This change already in the maintenance stream will be in 3.7.2.
Comment 10 Alexander Nyßen CLA 2011-09-12 10:36:18 EDT 
Ok, fine.