Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 145247

Summary: Eclipse 3.2 RC7 + Callisto RC4 Staging: UI frozen after clicking "finish"
Product: [Eclipse Project] Platform Reporter: Willian Mitsuda <wmitsuda>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Platform-Update-Inbox <platform-update-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: danny, david_williams, Mike_Wilson, mlists, stmoebius
Version: 3.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: obsolete

Description Willian Mitsuda CLA 2006-06-04 15:45:45 EDT
Forked from bug#144876 comment#46:

"I tested now with RC7 and Callisto RC4 staging area.

There is only one remaining issue: after selecting all Callisto projects,
accepting the license, and clicking finish, the UI becomes completelly frozen
for about 3 minutes.

After that, the download starts."

I'm using Sun JRE 1.5.0_06 on Windows XP SP2.
Comment 1 Danny Yates CLA 2006-06-05 04:55:36 EDT
Ditto for 1.5.0_07, XP SP2, 2Gb RAM, Centrino Duo T2400.
Comment 2 Branko Tripkovic CLA 2006-06-05 10:31:38 EDT
Better word is unresponsive. Without going into too many details, we are aware of this and it sure looks ugly. Be sure that at that point update is doing what it is suppose to be doing. This is simple but risky fix and we do not feel comfortable doing it this late. We will definitely fix this and download progress monitor in 3.2.1. (these two problems are very closely related).
Comment 3 Mike Wilson CLA 2006-06-05 10:37:15 EDT
Branko, are there bugs that describe the work you are doing/have done? (If so, you could mark this as a duplicate of one of them.)
Comment 4 Erik Wright CLA 2006-08-10 12:05:27 EDT
I've seen this behaviour on Fedora Core 5, JDK 150_04, eclipse 3.2.
Comment 5 Branko Tripkovic CLA 2006-08-10 16:54:40 EDT
Does this happen in M1, too? I did put some code in but i can not be sure since i fast internet connection.
Comment 6 Willian Mitsuda CLA 2006-08-10 17:09:30 EDT
(In reply to comment #5)
> Does this happen in M1, too? I did put some code in but i can not be sure since
> i fast internet connection.
> 

Does this depends on internet speed? When I opened this bug report, I tested it on a 4 mbps cable connection.
Comment 7 Branko Tripkovic CLA 2006-08-10 17:33:21 EDT
At that point we are opening connection to the server so it has to do with round trip to the server (network and server speed at the given moment). I tried to change that code to start download monitor before we open connection but i am not it fixed your problem. That is why i asked you to try it in M1.
Comment 8 Willian Mitsuda CLA 2006-08-10 17:39:48 EDT
OK, I'll try it out tomorrow as soon as M1 is declared.
Comment 9 Willian Mitsuda CLA 2006-08-11 18:18:14 EDT
Branko, it works well on 3.3 M1 + Callisto final Update Site.
Comment 10 Branko Tripkovic CLA 2006-08-11 22:23:00 EDT
thanks for testing it Willian. I am closing this bug as fixed.
Comment 11 Willian Mitsuda CLA 2006-08-12 14:54:29 EDT
Branko, I'm so sorry to say this, but today I tested at home, with 3.3 M1 and the bug persists.

My previous test was at my work machine, and I really don't know why it didn't happen (I'm completely sure the 2 tests ran on 3.3 M1).

I'll try again on monday.

Again, sorry for the mistake.
Comment 12 Branko Tripkovic CLA 2006-08-22 16:43:39 EDT
did some changes again and tested by putting a breaking point and it works for me.
Comment 13 Willian Mitsuda CLA 2006-09-02 11:53:21 EDT
This bug still occurs on 3.2.1 M20060830-0800, and 3.3 I20060830-1650.
Comment 14 Willian Mitsuda CLA 2006-09-02 12:32:52 EDT
I uploaded a flash video showing this bug occuring on M20060830-0800.

http://www.willianmitsuda.com/files/bug%23145247.swf
Comment 15 Willian Mitsuda CLA 2006-09-15 22:28:18 EDT
Branko, I think I located what could possibly be the problem: I debugged 3.2 and the slowdown appears while stepping over DuplicateConflictsValidator.computeNewFeatures(...) method.

It calls recursively computeNewFeature(...), who calls IIncludedFeatureReference.getFeature(...), that is a expensive operation because it tries to resolve the feature URL.

I noticed a little pause while stepping over IIncludedFeatureReference.getFeature(...), which together with the recursive approach could be getting into this noticeable GUI unresponsiveness.

Please, let me know if you need some more specific test.
Comment 16 John Arthorne CLA 2012-07-24 10:18:46 EDT
The Eclipse Update component is no longer under development, and no longer exists in the Eclipse Platform 4.x stream. If this problem still occurs in Eclipse Platform 4.2 or later, please enter a new bug report against Equinox p2.