Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 144297

Summary:	[Examples] Comments in example code: yuck: bad code smell
Product:	[Eclipse Project] Platform	Reporter:	John Arthorne <john.arthorne>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P5	CC:	djo
Version:	3.2	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows 2000
Whiteboard:	stalebug

Description John Arthorne

2006-05-29 15:26:20 EDT

Build id: I20060526-0010

I installed the example plugins into a workspace, and the first thing I see in the Resource perspective is a bunch of "todo" and "fixme" markers in the Tasks view. This includes comments like "auto-generated method stub" and "Yuck: Bad code smell here".  Example code that we display to users as exemplary usage of our APIs shouldn't be incomplete or have "bad code smell". It would be nice to clean this code up, or if the example really isn't ready, then remove it from the example set that we publish on the download page.

Here are the task markers in detail:
TODO 	InternalCompositeTable.java	org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/compositetable	line 284

TODO : eliminate flicker when scrolling backwards	CompositeTable.java	org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/compositetable	line 124

TODO Auto-generated method stub	Cart.java	org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/model	line 16

TODO Auto-generated method stub	Cart.java org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/model	line 21

FIXME : Yuck: bad code smell here...  (coupling with contentPane)	CompositeTable.java	org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/compositetable	line 408

Comment 1 Dave Orme

2007-05-16 09:45:34 EDT

Hmmmm.... CompositeTable is now in Nebula, and should be removed from Examples.

I don't know about cart.java

Comment 2 Eclipse Webmaster

2019-09-06 15:31:26 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 3 Eclipse Genie

2022-02-26 17:24:59 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.