Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 144115

Summary: [Accessibility]Can't change parameter value in chart builder without mouse
Product: z_Archived Reporter: Sue Lee <slee>
Component: BIRTAssignee: Yulin Wang <Lionel.wyl>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: lshen, xwang
Version: 2.1.0   
Target Milestone: 2.2.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 142655    
Bug Blocks:    

Description Sue Lee CLA 2006-05-28 03:48:53 EDT
Can't change parameter value in chart builder without mouse.

Steps to reproduce:
1. New a report
2. New a sample data soure
3. New a data set ds1
4. Add a parameter p1 in data set builder
4. Insert a chart to open Chart builder, switch to Select Data tab, use ds1 as
Data Set.
5. Use Tab key to navigate Select Data tab, when Parameters... button gets
focus, press Enter key, Parameters dialog shows up
6. Try to use keyboard to locate insertion caret in the cells of Value column

Expected result:
Can locate insertion caret in the cells of Value column

Actual result:
Can't locate insertion caret in the cells of Value column by keyboard
Comment 1 David Michonneau CLA 2006-06-06 12:30:28 EDT
Blocked by SWT bug: bug142655
Comment 2 Yulin Wang CLA 2007-08-08 22:28:01 EDT
Now user could press Space key to open expression builder to edit parameters without mouse.
As a standard behavior of dialog, pressing Enter key will still save parameters.
Comment 3 Maggie Shen CLA 2007-08-16 02:12:00 EDT
User can press Space key to open expression builder only if the parameter is hilighted with blue background. Another problem is that how to quit edit value mode. Enter key, Tab key or Space key makes no sense. (build 2.2.1 v20070816-0630)
Comment 4 Yulin Wang CLA 2007-08-16 03:24:53 EDT
(In reply to comment #3)
> User can press Space key to open expression builder only if the parameter is
> hilighted with blue background. Another problem is that how to quit edit value
> mode. Enter key, Tab key or Space key makes no sense. (build 2.2.1
> v20070816-0630)
> 

If user wants to use keyboard to edit, of course he has to make the control get focus first.
This accessibility enhancement makes sure user can edit/save parameters via keyboard. Space key is to edit parameter, Enter to save and Tab to traverse.
Comment 5 Maggie Shen CLA 2007-08-19 23:39:22 EDT
Verified on build 2.2.1 v20070820-0630.
Comment 6 Xiaodan Wang CLA 2007-08-24 03:56:32 EDT
Verified in build (2.2.1.v200708024-1416), closed.
Comment 7 Xiaoying Gu CLA 2007-08-24 04:40:18 EDT
Closed.