Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 14353

Summary: Cannot perform merge with keyboard accelerators/mnemonics
Product: [Eclipse Project] Platform Reporter: Randy Hudson <hudsonr>
Component: CompareAssignee: Andre Weinand <andre_weinand>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: csmclaren
Version: 2.0Keywords: accessibility, usability
Target Milestone: 2.1 RC1   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Randy Hudson CLA 2002-04-22 16:16:43 EDT
M5:

There are no accelerators to perform the Toolbar actions on the synchronize 
view.
Comment 1 Kevin McGuire CLA 2002-04-22 17:19:20 EDT
Most have mneumonics but a few don't.
Comment 2 Randy Hudson CLA 2002-04-22 17:53:58 EDT
I am on a pre-M5 build, so maybe I didn't see some of the new mnemonics.
Comment 3 James Moody CLA 2002-04-30 10:48:20 EDT
The items in the drop-down (Triangle) do have mnemonics.
But you're absolutely right, the actions in the toolbar (Incoming Mode, Outgoing
Mode, Both Mode, Show only Conflicts) have no accelerators. Will investigate.
Comment 4 James Moody CLA 2002-05-01 15:32:34 EDT
Randy, are you referring to the 'sync mode' toolbar items, or the 'copy left to
right' items?
Comment 5 Randy Hudson CLA 2002-05-01 16:39:05 EDT
I am refering to the "Next difference" and "Copy right to left".
These are the actions that you do repititiously.  I don't care if the modes 
aren't accessible, I only select them once per session.
Comment 6 James Moody CLA 2002-05-01 16:46:57 EDT
Thanks for the info. Moving to compare, as they contribute these toolbar items.
Comment 7 Randy Hudson CLA 2002-05-16 16:06:11 EDT
It would also be nice if there were a single action that would perform "Next", 
like in the search view.

In "Search", next will go through the current resource and show you 
the "hits".  When the last match is found, the *SAME* action takes you to the 
next resource's first hit, in this case a difference.

Synchronize view has 2 different actions with exactly the same icon.  This is 
confusing, and then once you've learned them, frustrating because you have to 
constantly mouse from one Toolbar to the other.
Comment 8 Tod Creasey CLA 2002-05-29 09:12:31 EDT
Usability rather than accessibility issue as there is nothing preventing access 
from the keyboar.
Comment 9 Randy Hudson CLA 2002-05-29 12:56:09 EDT
To clarify, the Keyboard User must do a...
Control+Shift+TAB
Control+Shift+TAB
Control+Shift+TAB
To get from the "Select Next Change" Toolbar button in the bottom pane, to 
the "Select Next Change" Toolbar button in the Top pane.

The *mouse* User sees 2 Toolbar Actions with exactly the same description, that 
do different things.

I was suggesting adopting the Search View's behavior of going to the next 
resource when the last "match" was found.  Currently, compare will prompt to 
wrap to beginning of document.

None of these Toolbar actions are available from the Main Menu when I am in the 
Java Perspective.  Why aren't they on the Navigate Menu?  Need accelerators for 
this.
Comment 10 Andre Weinand CLA 2002-05-31 16:39:38 EDT
In 20020601 there are new global actions for Next Difference and Previous 
Difference (the same actions as in Search and Editor). They step through all 
changes within a file (without going into token diffs), and go to the next file 
when reaching the end.
Comment 11 Erich Gamma CLA 2002-06-02 17:48:48 EDT
pls verify
Comment 12 Adam Kiezun CLA 2002-06-03 06:49:18 EDT
verified
Comment 13 Randy Hudson CLA 2002-06-03 11:18:24 EDT
Copy current change left to right, and the other 3 copy change Toolbar items 
still have no keyboard equivalents.

AFAIK, the Workbench does not have any action on the Toolbar that cannot also 
be invoked from the menu.
Comment 14 Erich Gamma CLA 2003-01-29 03:25:04 EST
we should address accessiblity by M5 so that the accessibility testing can start
Comment 15 Andre Weinand CLA 2003-02-19 16:33:29 EST
As stated in comment 8, the issue here is not accessability, but usabilty.
So accessibility testing isn't blocked. Lowering prio to P3.

So the remaining issue is to get keyboard equivalents for the "copy to"
toolbar items. Will try to get that fixed for RC1.
Comment 16 Randy Hudson CLA 2003-02-20 10:17:17 EST
As a keyboard user, in my opinion there is not currently a 
keyboard "equivalent".  It there were, why am I still using the mouse to do 
these action ;-?  Are these actions going to be avialable in the keybindings 
dialog?
Comment 17 Andre Weinand CLA 2003-02-20 10:36:52 EST
Which is exactly what I said in comment 15:
"So the remaining issue is to get keyboard equivalents for the "copy to" toolbar items. Will 
try to get that fixed for RC1."

Comment 18 Andre Weinand CLA 2003-02-20 13:10:26 EST
fixed and released for RC1
the following actions are now available via key bindings:
Copy from Right to Left
Copy from Left to Right
Copy All from Right to Left
Copy All from Left to Right
Select Next Change
Select Previous Change
Comment 19 Randy Hudson CLA 2003-02-20 13:59:45 EST
Excellent!  I hope the compare browser declares its own "compare" scope, 
otherwise I'll have pseudo conflicts with the rest of the Actions in Eclipse 
that are incorrectly scoped as "global", For example "Organize Imports".
Comment 20 Andre Weinand CLA 2003-03-06 05:21:35 EST
[Reopening in order to setting it to "Fixed"]
Comment 21 Andre Weinand CLA 2003-03-06 05:23:29 EST
General scoping wasn't planned for 2.1.
So I cannot do anything here.
Comment 22 Randy Hudson CLA 2003-03-06 09:56:47 EST
I'm confused.  What does "General scoping wasn't planned for 2.1.
So I cannot do anything here." mean, in conjunction with resolved->fixed?  Was 
a "compare" scope added?
Comment 23 Nick Edgar CLA 2003-03-06 13:01:02 EST
For 2.1, we are not going to introduce scopes for each view.
Only the text editor and possibly the java editor will have scopes.

We need to think more about scoping and don't want to introduce them 
gratuitously.