Bugzilla – Full Text Bug Listing
| Summary: | [Actions] Allow to set MODE_FORCE_TEXT in Action | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Benjamin Pasero <bpasero> | ||||
| Component: | UI | Assignee: | Paul Webster <pwebster> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P5 | CC: | 0001rajesh, aschmid, cvogt, mlists, sr | ||||
| Version: | 3.2 | Keywords: | helpwanted | ||||
| Target Milestone: | 3.4 M6 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Benjamin Pasero
"MODE_FORCE_TEXT should be a selectable option of an Action" is better to read as "MODE_FORCE_TEXT should be a selectable option of an Action being declared in the plugin.xml" Ben Is this still a problem in 3.3? PW Yes, nothing changed (3.3 M2). Ben With the work in bug 154130 I hope to never see an action again ... this might be left behind. PW Right. Once that bug is fixed it would be great if it was possible to do anything SWT allows to do with Toolbars/Menus in an extendable way via extension points / contributions. Ben Any update on this? This didn't make it in, and we're in API freeze. PW (In reply to comment #7) > This didn't make it in, and we're in API freeze. > > PW > Will it be in M7 ? Would be great. (In reply to comment #8) > (In reply to comment #7) > > This didn't make it in, and we're in API freeze. > > Will it be in M7 ? Would be great. > Sorry, API freeze means not in 3.3 PW If this was available it would have to be included in org.eclipse.ui.menus/command as well PW This will cover a way to mark commands in org.eclipse.ui.menus to use both text and an icon PW If someone would like to contribute a patch for this we can get it into M6: - the action element in org.eclipse.ui.actionSets, org.eclipse.ui.editorActions, and org.eclipse.ui.viewActions needs to be updated ... and the information probably stored in the IActionDescriptor - All the contributors that create/build PluginActions for views,editors, and actionSets need to set the option on the PluginActionContributionItem (ALT+CTRL+H on the constructor will show them). - it has to be added to the command element in org.eclipse.ui.menus - It has to be added/set on CommandContributionItem, probably from MenuAdditionCacheEntry PW *** Bug 220082 has been marked as a duplicate of this bug. *** I need at least the action portion of this by early Monday if this is to make it into 3.4 PW Created attachment 93338 [details]
Force mode in actions and commands v01
Adds a mode attribute to action elements and the command element
PW
Released to HEAD >20080324 PW Thanks Paul. Make sure to ask me for some beers next EclipseCon. Well deserved :). In I20080325-0100 PW |