Bug 142882

Description Alex 2006-05-20 02:20:18 EDT

There is a case which will cause the "Move Member Type to New File" refactoring to make inconsistent code changes. This occurs when two classes in the same namespace contain a sub-type with the same name and there is a reference in one class to the sub-type from the other class. Example:

Foo.java:
class Foo {
  class Inner {
  }
}

Bar.java:
class Bar {
  class Inner {
  }
  Foo.Inner someFunction() {
    return new Foo.Inner();
  }
}


Executing the "Move Member Type to New File" on Foo.Inner causes the return type for someFunction() to be changed to just "Inner" which then refers to Bar.Inner. Ie the code will look like this after the refactoring:

Foo.java:
class Foo {
}

Inner.java:
class Inner {
}

Bar.java:
class Bar {
  class Inner {
  }
  Inner someFunction() {
    return new Inner();
  }
}

This is clearly a problem because someFunction() now returns a completely different type.