Bugzilla – Full Text Bug Listing
| Summary: | Remove import and export from Correlations pop-up | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Malcom Zung <zung> | ||||||||||||
| Component: | TPTP | Assignee: | Yasuhisa Gotoh <gotohy> | ||||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P1 | CC: | apnan, hgr, jacalcat, jkubasta, labadie | ||||||||||||
| Version: | unspecified | Keywords: | plan | ||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Hardware: | PC | ||||||||||||||
| OS: | Windows XP | ||||||||||||||
| Whiteboard: | closed460 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Malcom Zung
Setting to P1 since it can be fixed in the first week of i3. The general import/export menu items were replaced with "Import Log File", "Import Symptom Database", and "Export Symptom Database" actions in 4.3. See the snapshot attached. I'm going to mark this defect as invalid. Please feel free to re-open if you think there were usability issues that were not addressed. Created attachment 52794 [details]
The context menu of a correlation item
Please reopen this defect, as the current implementation done in the context menu associated with correlation still presented options that are not valid for the object selected. This implementation does not meet Eclipse UI guidelines nor general Windows application guidelines. This one of the items in the usability criteria for RCP . Context Menus A context menu should be used for context sensitive interaction with the objects in an editor. If an object is selected in an editor, and the context menu is opened, the context menu should only contain commands which are appropriate for the selection. Commands which affect the presentation of the view should not appear in the context menu. In a text editor, you may assume that there is only one type of selection: text. In this case, the contents of the context menu will remain consistent for any selection in the editor. Context Menus A context menu should be used for context sensitive interaction with the objects in an editor. If an object is selected in an editor, and the context menu is opened, the context menu should only contain commands which are appropriate for the selection. Commands which affect the presentation of the view should not appear in the context menu. In a text editor, you may assume that there is only one type of selection: text. In this case, the contents of the context menu will remain consistent for any selection in the editor. From Eclipse Guidelines 2.1: http://www.eclipse.org/articles/Article-UI-Guidelines/Contents.html "Context Menus A context menu should be used for context sensitive interaction with the objects in an editor. If an object is selected in an editor, and the context menu is opened, the context menu should only contain commands which are appropriate for the selection. Commands which affect the presentation of the view should not appear in the context menu. In a text editor, you may assume that there is only one type of selection: text. In this case, the contents of the context menu will remain consistent for any selection in the editor." Guideline 6.11 Fill the context menu with selection oriented commands. Reopening this defect based on Humberto's comments. This is not a stop ship defect for 4.3 and will be addressed in the 4.4 time-frame. Added Jeff Calcaterra as interested party in the CC list. Target to future. Cannot be contained in 4.4 due to limitation of resource. This is required from AC perspective. Via extension point. Targetting 4.5 i2. Changing target to 4.5 i4. Reassigning to Gotoh-san. Assigning to i6. Created attachment 92019 [details]
Patch file
Alex, here is the patch. Please review.
Gotoh-san I have reviewed the patch but I personally would rather place the logic of showing or hiding into the actions themselves instead of the log navigator action contributor. Created attachment 92100 [details] Proposal patch for bug 142823 Attaching proposal for bug 142823. Gotoh-san please review and check in, the code is in the monitoring project this time. Thanks. Created attachment 92101 [details] Updated proposed patch for bug142823 Sorry, I missed to remove a redundant method in my previous patch. Created attachment 92112 [details]
Updated path
I have also added the logic for hiding the Import Log File menu.
Fix checked in. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |