Bugzilla – Full Text Bug Listing
| Summary: | [Intro] TVT3.2:TCT557: AR: Base Welcome: Text should be mirrored. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | CDE Administration <cdeadmin> | ||||||||||
| Component: | User Assistance | Assignee: | platform-ua-inbox <platform-ua-inbox> | ||||||||||
| Status: | RESOLVED WORKSFORME | QA Contact: | |||||||||||
| Severity: | major | ||||||||||||
| Priority: | P2 | CC: | camle, Karice_McIntyre, kitlo, Tod_Creasey | ||||||||||
| Version: | 3.3 | ||||||||||||
| Target Milestone: | --- | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Linux-GTK | ||||||||||||
| URL: | 557 | ||||||||||||
| Whiteboard: | |||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 146237 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
CDE Administration
Created attachment 41932 [details]
Tutorials.JPG
<cde:tctdetail> Testcase: 01.001080 Project: WSW32 Component: CDE - Platform/UI Priority: 2 Subject: AR: Base Welcome: Text should be mirrored. Article ID: 557 Originator: ROUSHDY@EG.IBM.COM </cde:tctdetail> I recall seemingly similar bugs in the Welcome pages in the past: bug 105737, bug 81986. Has anyone looked at this bug? What is the status? Curtis, alternative CSSs for themes need to be supplied for RTL languages. HTML has the attribute 'direction' with values 'ltr' and 'rtl' that can be applied to the elements in question. Can you investigate which CSS files will need to be supplied in the NL directories in order to get the required direction? It is unrealistic to expect that we will make a complete RTL Welcome (flipping images, the entire layout RTL etc.) for 3.2. See which files need to be supplied at a minimum to resolve the paragraphs circled in the attached picture. Could someone help me understand exactly what needs to be mirrored? I'm assuming it's not all the circled text, since that would result in mirrored english text (java -> avaJ ?). Should the layout change at all, i.e. should the images be on the other side of the text? Or just the translated text should be mirrored onto itself? If you can send me an image of the desired result that would help. Created attachment 42350 [details]
new nl contents for org.eclipse.ui.intro.universal.nlBidi fragment
(Nevermind my last comment, I think I understand now)
I believe the proper fix should not require any work on the part of the author, since the forms implementation knows what to do here. However this would require code changes and this is not the time to do it, especially since there is a good workaround:
The workaround is to add a shared.css file for each right-to-left locale which explicitly sets the direction and unicode-bidi styles on specific classes. It should not be set on the entire content (e.g. html or body element), as this will cause layout problems.
I've attached an updated copy of org.eclipse.ui.intro.universal.nlBidi's nl folder. It contains the new shared.css files for ar and iw locales and the proper directory structure. Please ignore the introContent.xml files in the zip, I did not change them.
I will attach a screenshot of welcome with the fix.
Created attachment 42351 [details]
screenshot with fix
Can the tester confirm that this screenshot shows the correct output?
Forgot to mention, I did see the bug with the RCP item brackets: "(Rich Client Platform (RCP [arabic]" whish should probably be "Rich Client Platform (RCP) [arabic]". The HTML and CSS look fine on this one. I don't know why the browser is showing it this way. It would appear to be a browser bug. To avoid the bug, you can simply omit the acronym altogether, it is not really necessary. Curtis, we've confirmed the css's fixes the reading order for bidi languages (Arabic and Hebrew). However, the layout (like the top row of buttons, the image in front of the paragraph, and the left adjusted text alignment of the paragraph) is not mirrorred. Can that be fixed in a css? The Welcome page is the first impression of the product. We really should try to fix this in this release. Note: there is a line of description under the heading. They do not display. (Seems like only for bidi.) Here are the keys from platform\plugin.properties introDescription-overview = Eclipse is a kind of universal tool platform - an open extensible IDE for anything and nothing in particular. It provides a feature-rich development environment that allows the developer to efficiently create tools that integrate seamlessly into the Eclipse Platform. introDescription-tutorials = Learn how to be productive using Eclipse by completing end-to-end tutorials that will guide you along the way. introDescription-samples = Explore Eclipse by installing prefabricated samples (may require Internet connection). (In reply to comment #10) > Curtis, we've confirmed the css's fixes the reading order for bidi languages > (Arabic and Hebrew). However, the layout (like the top row of buttons, the > image in front of the paragraph, and the left adjusted text alignment of the > paragraph) is not mirrorred. Can that be fixed in a css? It probably can, but would definitely be non-trivial. > The Welcome page is > the first impression of the product. We really should try to fix this in this > release. While I agree it's important, it's unfortunately not very realistic to have this fixed for 3.2. We have already passed the final release candidate so a fix on our side is not possible. > Note: there is a line of description under the heading. They do not display. > (Seems like only for bidi.) Here are the keys from platform\plugin.properties > introDescription-overview = Eclipse is a kind of universal tool platform - an > open extensible IDE for anything and nothing in particular. It provides a > feature-rich development environment that allows the developer to efficiently > create tools that integrate seamlessly into the Eclipse Platform. > introDescription-tutorials = Learn how to be productive using Eclipse by > completing end-to-end tutorials that will guide you along the way. > introDescription-samples = Explore Eclipse by installing prefabricated samples > (may require Internet connection). The problem is in org.eclipse.ui.intro.universal.nlBidi/nl/ar/introContent.xml in the overview page element > page content group > page-description text... this line: <text style-id="page-description" id="page-description">$introDescription-*******$</text> (**** = translated arabic text) The $$s are used to refer to variables, so they should not be translated. The line should remain as: <text style-id="page-description" id="page-description">$introDescription-tutorials$</text> Same for the other sections. There is also an additional problem in org.eclipse.pde.nlBidi/nl/ar/intro/tutorialsExtensionContent.xml, this line: label="****** Rich Client Platform (RCP)‎ " This is an XML file so unfortunately you cannot use ‎. The XML parser does not understand this and will halt parsing, causing this extension to be missing from the tutorials page. Curtis, is it possible to target this for 3.2.1? For the original problem yes, for the layout, I'm not sure, I would have to ask Dejan how much is involved here. Kit, could you open a separate bug for the layout problem? I opened Bug 146237 to track the welcome page layout problem. I constructed an image to show how the welcome page should look like. Please see the attached file. Please upload the image to bugzilla 146237. Created attachment 44016 [details]
Welcom.JPG
I believe there are at least 2 separate problems in this bug, one of which (the layout) has been spawned off to bug 146237. Curtis, are the remaining issues covered by this bug fixed (I noticed it was mentioned that the description under the heading is not displaying - is that another bug)? If so, this one should be marked as fixed and the layout bug can be addressed in 3.2.1. 1. layout - tracked in separate bug 146237 2. missing description - problem with translated files, explained in comment #11, to be fixed in nl plugins by translation team 3. original problem - not yet fixed properly, but workaround implemented in nl plugin. see comment #7 This bug is left open to track #3. Once fixed, the workaround of the extra CSS can be removed. Sounds good. Thanks! Actually this one is probably not needed for 3.2.1 since there won't be another translation pass for this one. Since the workaround needs to be removed from the nl plugin, may as well wait for the next translation pass (3.3). Workaround is working fine so user doesn't see the problem, downgrading to normal. Defer unless already fixed. Curtis, the shared.css is not working in 3.3 (for both Arabic and Hebrew). Anything changed? Unfortunately no, we didn't get to this one in 3.3. Sending back to inbox for now. Curtis, just to clarify. I meant the shared.css file was a work around for 3.2, and it fixed the mirroring problem in 3.2. But, now it's not working in 3.3 (for both Arabic and Hebrew). Upping to major - this is the first thing a user sees when they open up Eclipse. Do you think you will be able to get to it in 3.3.1? I'll make an assessment of the work involved and see if we can get it in. I agree that this bug needs to get fixed. Targeting Eclipse 3.4. If I can create a low risk fix for Eclipse 3.3.1 I will release for 3.3.1 also. The part that's not working in 3.3 actually is covered by bug 146237. Therefore, we may resolve this bug and work on bug 146237. Resolving (see previous comment). |