Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 141926

Summary:	Need to have common logging component shared by TPTP and WTP
Product:	z_Archived	Reporter:	Kathy Chan <kathy>
Component:	TPTP	Assignee:	Hubert Leung <hkyleung>
Status:	CLOSED FIXED	QA Contact:
Severity:	blocker
Priority:	P1	CC:	cbrealey, joan, paulslau, popescu, srinivas.p.doddapaneni, thays, zung
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:
Bug Blocks:	143951

Description Kathy Chan

2006-05-15 23:04:21 EDT

We are unable to run any Web servcies Ant tasks with both WTP and TPTP present.  It works OK when only WTP 1.5 is present but fails as soon as TPTP plugins are there as well.  

The error is:

org.apache.commons.logging.LogConfigurationException: Invalid class loader hierarchy.  You have more than one version of 'org.apache.commons.logging.Log' visible, which is not allowed.

It turns out that the org.apache.axis defines commons-logging-1.0.4.jar and log4j-1.2.8.jar (not exported).  This plugin is in WTP.  However, TPTP also shipps a common-logging and log4j plugin.
 
I think the approach that could work is for you guys to not contribute the common.logging and log4j plugin through TPTP.  Instead, those plugins (the versions that would work for both of us) would be moved down to WTP.  We could then change our org.apache.axis plugin to depend on those plugins in WTP and you would use those plugins in WTP as well.  This would solve the problem of multiple copies of the same JARs available through different plugins.

Here are the versions of we need for the org.apache.axis plugin:

- commons-logging-1.0.4.jar (dated 06/15/2004)
- log4j-1.2.8.jar (dated 02/20/2003)

Here are the versions in the plugins you shipped:

- commons-logging-1.0.3.jar (dated 04/07/2003)
- log4j-1.2.8.jar (dated 01/12/2006)

Would it be OK for you guys to move to the versions we need?

We need to solve this ASAP for Callisto since this is blocking our Web Services Ant task from functioning properly.

Comment 1 Sri Doddapaneni

2006-05-16 15:11:18 EDT

Kathy, 

We will need legal approval for TPTP to ship commons-logging-1.0.4.jar. I am driving this process.

Assuming TPTP moves to the same version as currently shipped by WTP, would it be easy for WTP to consume the plugins from TPTP CVS repository?

TPTP plugins are located at:
/home/tptp/platform/org.apache.jakarta_commons_logging
/home/tptp/platform/org.apache.jakarta_log4j_logging

If WTP already has such plug-ins, indicate CVS location for them.

Comment 2 Kathy Chan

2006-05-18 10:43:23 EDT

The following plugins and features had been created for common-logging and log4j in WTP 1.5 and dropped into WTP 1.5 and is already in RC3 driver such as:

http://download.eclipse.org/webtools/committers/drops/S-1.5RC3-200605181223/ or
http://download.eclipse.org/webtools/committers/drops/S-1.5RC3-200605180627/

These will be in the WTP RC3 driver to be declared this week on 05/19:

- org.apache.commons_logging_1.0.4
- org.apache.jakarta_log4j_1.2.8
- org.apache.commons_logging.feature_1.0.4
- org.apache.jakarta_log4j.feature_1.2.8

These plugins and features can be found in dev.eclipse.org:/cvsroot/webtools under:

wst/components/ws/thirdparty/org.apache.commons_logging
wst/components/ws/thirdparty/org.apache.jakarta_log4j

wst/components/assembly/features/org.apache.commons_logging.feature
wst/components/assembly/features/org.apache.jakarta_log4j.feature

Please use these these plugins and do not shipp another version of these plugins in the TPTP build.  Please let me know if there's any concern over this change and let us know your outlook of when this could be done by.

Comment 3 Hubert Leung

2006-05-19 10:56:32 EDT

TPTP build TPTP-4.2.0-200605190100 is using the log4j and commons logging plugins and features from WTP. 

However, there are some packaging problems with the 2 features.  Both features are missing epl-v10.html and notice.html.  The log4j feature is also missing the feature.properties.  I have opened bug 142767 to fix this problem.  

On the other hand, since these two features will now be shared between projects. Please work with Callisto to put these two features under the Enabling Feature section. So projects that depend on these features don't need to download the whole WTP.  I have opened bug 142770 to track this.

Comment 4 Paul Slauenwhite

2006-05-24 10:38:17 EDT

*** Bug 143320 has been marked as a duplicate of this bug. ***

Comment 5 Paul Slauenwhite

2006-05-24 12:13:39 EDT

Updated the follow Agent Controller config generator classes since they were not
resolving the Apache Commons plugin based on the version update (1.0.3 to 1.0.4) committed under this defect:

org.eclipse.hyades.execution\src-local\org\eclipse\tptp\platform\agentcontroller\internal\impl\FileConfigurationImpl.java

org.eclipse.tptp.platform.examples\archive\HyadesLoggingCommonsSample\src\HyadesLoggingCommonsSample.java

Comment 6 Paul Slauenwhite

2006-05-25 10:45:52 EDT

(In reply to comment #5)

Also updated the follow Agent Controller config generator classes since they were not resolving the Apache Commons plugin based on the location of its JAR (e.g. lib directory):

org.eclipse.tptp.platform.agentcontroller\src-config\org\eclipse\tptp\platform\agentcontroller\config\ConfigUtility.java

org.eclipse.tptp.platform.agentcontroller\src-config\org\eclipse\tptp\platform\agentcontroller\config\SetConfig.java

Comment 7 Dave Smith

2006-05-30 00:14:31 EDT

*** Bug 144316 has been marked as a duplicate of this bug. ***

Comment 8 Kathy Chan

2006-06-14 10:11:37 EDT

Verified with WTP RC5 candidate I0613.