Bugzilla – Full Text Bug Listing
| Summary: | Use JVMTI instead of JVMPI to get event notification | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Navid Mehregani <nmehrega> |
| Component: | TPTP | Assignee: | Liz Dancy <lizdancy> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P1 | CC: | asaf.yaffe, guru.nagarajan, jkubasta, paulslau, te, viacheslav.g.rybalov, vss |
| Version: | unspecified | Keywords: | plan |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| URL: | http://eclipse.org/tptp/groups/Architecture/documents/features/hf_141540.html | ||
| Whiteboard: | closed460 | ||
| Bug Depends on: | 182750 | ||
| Bug Blocks: | |||
| Attachments: | |||
|
Description
Navid Mehregani
This enhancment must be implemented to make Probekit Java-1.6-ready. Adding Vsevolod to the CC list so we can communicate our progress using this enhancement. Vsevolod, could you clarify what your status is, specifically what you mean by working on having the agent ready in standalone mode (what does standalone mode refer to in this implementation)? Do you have code that automatically registers itself when the RAC starts similar to the piAgent? This link explains what standalone mode is: http://help.eclipse.org/help32/index.jsp?topic=/org.eclipse.hyades.probekit.doc.user/topics/t_pk_deploy_sa_linux.htm (or just search for Using Probekit in stand-alone mode) The standalone mode in new implementation should start working this week. Communication with Agent Controller is planned for the next week. Created attachment 64054 [details]
Patch for preliminary UI changes
I have some UI code ready for committal. I have disabled the new JVMTI profiling type for now but the code involved a refactoring of the JVMPI Probe analysis UI code as well so I would like to get it in so it can be tested sooner.
Navid, can you review the new structure when you have time and particularly let me know if all of the new Strings are satisfactory (new description etc.) so that I can create the TVT test cases?
I get compile errors in org.eclipse.tptp.platform.probekit.launch.internal.config.ProbekitProfilingType when I apply the patch to the plug-ins right out of HEAD. I apply the patch to the following plug-ins: org.eclipse.tptp.platform.probekit.launch org.eclipse.tptp.platform.jvmti.client org.eclipse.hyades.trace.ui Created attachment 64200 [details]
Patch for HEAD April 17, 2007
Please use this current patch. I just tested it on the plugins from HEAD. Be advised that the icon will not show up unless you copy and paste the correct .gif file into the icons folder in the jvmti plugin.
Created attachment 64202 [details]
Patch for HEAD April 17, 2007
I left the Edit Options Dialog in this patch for you to review but when I commit the code I will also disable this until the remainder of the enhancement is checked in. I left the Edit Options Dialog in this patch for you to review but when I commit the code I will also disable this until the remainder of the enhancement is checked in. Created attachment 64210 [details]
Delta TVT test cases
I have attched the Delta TVT test cases. As far as I know, the statistics results view will not require any UI changes, Navid, please comment if otherwise.
Liz, I finished reviewing the changes. Everything looks great, I just have a couple of minor suggestions: - Please include comments for all the new classes created. Also if you think there is inadequate commenting for any of the existing code, please feel free to add in your comments. - Please remove all *commented code* from the classes at the end of your work. UI code was checked in to HEAD on 04/20/2007. The remainder of the code will be checked in once it is tested and integrated. Created attachment 64938 [details]
Patch for execution of JVMTI probekit (client side)
I have attached the second part of my client code. This handles the flow of control during execution for JVMTI. Navid, could you please review when you have the time?
Created attachment 65067 [details]
Client side Launch Configuration AutomatedTest Suite
Created attachment 65068 [details]
Client Side Launch Configuration Verification Hook Class
I have attached an AGR test suite and verification hook class for the Launch Configuration UI. Navid, please review and commit to org.eclipse.hyades.probekit.tests. A second AGR test suite which tests the full execution is to come. Liz, I don't think it's necessary to review the AGR test cases given your AGR skills. I feel comfortable with you checking in the test cases. You should have committer access to the test-results folder. Let me know if you don't. Test Suite and Verification Hook Class have been checked in to HEAD. Client side code checked in to HEAD. (Note that because the agent extension is missing the Probe Insertion Analysis Type remains disabled in the Launch Configuration UI). Vesevolod, please attach your code as a patch to the defect when ready so we can review and check in. Testing has revealed that 182750 is causing a timeOutException in multiple Probe Insertion Profiling attempts. Adding dependency on this defect. (In reply to comment #21) As far as I know, the new JVMTI Probekit agent can be launched only in "controlled" mode (e.g., through the Eclipse workbench UI, with the command line: "JPIAgent:server=controlled"). This is not considered to be a "dynamic attach" scenario so I am not sure whether the dependency on Bugzilla 182750 is correct. Please clarify how the timeout issues you experience are related to 182750. You are correct that it is only started in controlled mode. I was referred to this defect by Guru after explaining a TimeOutException I am getting where the process does not seem to launch after multiple profiles. (Process launch times out before it even gets to the probekit launch pad). Perhaps this is not the right dependency? From emails yesterday my understanding was that the VM was not initialized and hence you had an issue in attaching to the Agent. The 182750 is enabling the retries on the connect as to when the agent will be ready for attach. There should be a patch attached shortly that will have the fix for it. It is applicable for both the controlled and the attach scenarios Created attachment 65838 [details]
Patch for size limit restriction
I am attaching a patch which was necessary after we ran into a size restriction for messages on the agent side. The patch coordinates our solution on the client side by sending each probe's supporting files in its own command. Navid, please review and commit if suitable.
Created attachment 65909 [details] Dynamic Probekit support patch for JVMTI Runtime component JVMTI runtime support for Dynamic Probekit. Written by Vsevolod Sandomirskiy (vss@ocsystems.com) Comment on attachment 65909 [details]
Dynamic Probekit support patch for JVMTI Runtime component
Patch checked in to HEAD
Created attachment 65934 [details]
Enable the JVMTI Probe Insertion in new driver
This patch removes the temporarily Disabled message and allows the probe insertion profile with JVMTI. It should be checked in so that the test driver for next week will allow testing of this function.
AGR test suite for client code checked into HEAD. Code for both client and agent has been checked in as of Friday. Closing defect. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |