Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 141205

Summary: Script error when using total in chart bookmark and define link.
Product: z_Archived Reporter: Liwen Chen <lchen>
Component: BIRTAssignee: Yulin Wang <Lionel.wyl>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: dmichonneau, qwang
Version: unspecified   
Target Milestone: 2.2.0 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard: Non-Auto
Bug Depends on: 132768, 187496    
Bug Blocks:    
Attachments:
Description Flags
report design none

Description Liwen Chen CLA 2006-05-11 03:08:03 EDT
Description:
Script error when using total in chart bookmark and define link.

Steps to reproduce:
1. Insert a chart
2. Define a bookmark like Total.count(null,0) 
3. Insert a label and define internal bookmark link with expression 3. (3 is count result)
4. Preview
See attached report.

Expected result:
No errors.

Actual result:
A Runtime Error has occurred.
Do you wish to Debug?

Line:34
Error: Expected ';'
Comment 1 Liwen Chen CLA 2006-05-11 03:09:00 EDT
Created attachment 41075 [details]
report design
Comment 2 Jun Ouyang CLA 2006-05-11 04:40:02 EDT
No this problem in latest version. Please verify.
Comment 3 Liwen Chen CLA 2006-05-12 05:28:07 EDT
REOPEN IT.
Comment 4 Jun Ouyang CLA 2006-05-12 05:37:33 EDT
The error only occurs when the chart type is "svg" and the bookmark includes total function.

Is this because the chart is not support total funciton and will cause the problem of svg?
Comment 5 David Michonneau CLA 2006-05-13 03:08:07 EDT
Chart does not support total, it has been removed from the expression builder 
in chart in the latest build, please verify.
Comment 6 Liwen Chen CLA 2006-05-15 01:47:48 EDT
In latest build, I still can define such bookmark in Property Editor for chart, so this issue still exists.
If chart doesn't support total in Property Editor, I think this bug's resolution should be won't fix
Comment 7 David Michonneau CLA 2006-05-15 05:05:19 EDT
we need to disable total in expression builder in property editor too. Is it 
possible?
Comment 8 Wenfeng Li CLA 2006-05-15 18:21:58 EDT
please see David's comment on diabling total is property editor.  
Comment 9 Wenfeng Li CLA 2006-05-15 18:22:48 EDT
(In reply to comment #8)
please see David's comment on disabling totals in property editor.  

Comment 10 David Michonneau CLA 2006-05-17 09:24:33 EDT
It looks like we can't disable the total in property editor. I reassign to UI 
team to give more control on the expression builder from the property editor 
for extended items.
Comment 11 Wang Qiangsheng CLA 2006-05-17 22:38:56 EDT
At GUI side, we can know if the extended item support total or not.
That control have to be done by chart.
GUI can provide more api to help chart do it.
Comment 12 David Michonneau CLA 2006-05-18 03:26:15 EDT
We indeed need this API from the GUI team.
Comment 13 David Michonneau CLA 2006-05-18 14:59:40 EDT
Reassigning to GUI team to get additional API, that's actually what I meant in 
comment#10.
Comment 14 David Michonneau CLA 2006-05-18 15:05:14 EDT
Reassigning to GUI team to get additional API, that's actually what I meant in 
comment#10.
Comment 15 David Michonneau CLA 2006-05-18 15:10:13 EDT
Reassigning to GUI team to get additional API, that's actually what I meant in 
comment#10.
Comment 16 Wang Qiangsheng CLA 2006-05-18 22:25:43 EDT
As discussed with Zhiqiang, looks GUI can't help for this issue.
Can chart team provide more info about the api you need?
Comment 17 David Michonneau CLA 2006-05-19 03:10:35 EDT
Yulin, please detail what API is needed from the designer side to implement 
that behavior.
Comment 18 Yulin Wang CLA 2006-05-22 05:22:21 EDT
There are uncertain factors to fix this, such as how to support customized pages in designer side.
Comment 19 David Michonneau CLA 2006-05-22 16:09:36 EDT
deferred to future as requested by designer team, due to the complexity of 
introducing an extension point at such a late stage of the release.
Comment 20 Yulin Wang CLA 2006-10-11 05:08:31 EDT
Suggest deferring this, since it needs to implement a customized UI in property editor
Comment 21 David Michonneau CLA 2007-04-09 10:17:45 EDT
Does the new property editor framework support this?
Comment 22 Wang Qiangsheng CLA 2007-04-09 17:40:04 EDT
Yes, We already provide the extensible property editor framework.
Comment 23 David Michonneau CLA 2007-05-16 11:53:39 EDT
Is this an obsolete issue? We should support total by now, it has been moved in 
the databinding definition anyway?
Comment 24 Yulin Wang CLA 2007-05-17 01:28:20 EDT
Engine has supported Total now. It's indeed an obsolete bug. We will enable UI for Total in chart builder, and do not need to change property editor any more.

Note that in attached report, link to bookmark should be 2.
Comment 25 Yulin Wang CLA 2007-05-24 23:22:22 EDT
Total in expression builder is invisible by default (see Bug#187496), and chart builder will remove the expression filter to use the default expression trees.
However, for this bug, Total function still works even if it can not be selected from expression builder.
Comment 26 Liwen Chen CLA 2007-05-27 22:02:12 EDT
Verify in build 2.2.0.v20070528