Bugzilla – Full Text Bug Listing
| Summary: | TVT3.2:TCT376: RU: Truncation in DTD editor - Properties | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | CDE Administration <cdeadmin> | ||||||||||||||||||
| Component: | wst.dtd | Assignee: | Amy Wu <for.work.things> | ||||||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||||||
| Severity: | normal | ||||||||||||||||||||
| Priority: | P2 | CC: | camle, for.work.things, jeffliu, kitlo, valentinbaciu | ||||||||||||||||||
| Version: | 1.5 | ||||||||||||||||||||
| Target Milestone: | 2.0 M6 | ||||||||||||||||||||
| Hardware: | PC | ||||||||||||||||||||
| OS: | Linux-GTK | ||||||||||||||||||||
| URL: | 376 | ||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||
| Bug Blocks: | 138008, 141446 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
CDE Administration
Created attachment 40983 [details]
376-28.002340.gif
Created attachment 40984 [details]
376-28.002340a.gif
Created attachment 40985 [details]
28.002320.gif
<cde:tctdetail> Testcase: 28.002320 Project: WSW32 Component: CDE - Web Tools/wst.dtd Priority: 3 Subject: RU: Truncation in DTD editor - Properties Article ID: 376 Originator: rusmil01@ru.ibm.com </cde:tctdetail> Hello Japan has the same problem. This problem is a must-fix for Japanese. Please investigate. Thank you Eriko Takahashi Hi Same problem for France, must fix too. Nathanaël Created attachment 41014 [details]
TCT376_28.002330.jpg
Created attachment 41015 [details]
TCT376_28.002320.jpg
Nitin, is that label something we have control over? Especially how it is truncated. I noticed that if you hover over the label control, the full name will be displayed in a hover. If you are able to get the full name somehow, is this still a mustfix for Japanese and French? Same problem for Norway. Ellen Elisabeth Hi, I had hard time thinking about that. I really think that problem impacts the usability of the product. It's still a must fix for France even though the tooltip shows the whole field name. Same as France, it's a must-fix for Japanese. We need to have it fixed for the usability. The text needs to be displayed fully without hovering over it. Please help to fix this problem. Eriko Currently, labels are basically given a fixed width of 100 pixels. Fix is to calculate label text first and if text is greater than 100 pixels, allow it (and shift all other controls to the right of it) If text is < 100 pixels, still keep label width at 100 pixels to align controls better. (if label text is greater than 100 pixels, only that row of controls will be shifted. all other rows of controls will maintain original alignment) Created attachment 41799 [details]
org.eclipse.wst.dtd.ui.patch
Fix is for all tabbed property sections, create label first and check label text length and adjust size accordingly so there is no truncation. Then attach the other controls to the label (so shift other controls with respect to label)
This is a lot code, but its all systematic application of same principles, so I believe safe, and approve it for RC3. Warning: Unable to attach org.eclipse.wst.dtd.ui.patch due to unsupported extension (patch) on the filename. Fix released for this week's build. Nathana?l Nathana?l In 0606 build it is fixed for ru_RU, but not fixed for ja_JP. This truncation problem is not fixed for Japanese with 0606 build. Please investigate. Do you have some screencaps to show it still not working? Is the truncation any better (less is truncated)? Yes, it's better than before. But it still has truncation. For example, for "Model Group", three double byte characteres are not shown. Please help to fix this problem. Created attachment 43859 [details]
TCT376_ja.jpg
Just setting to untargeted. Sounds like partially fixed in 1.5 RC3, but more work may be needed next release. re-targeting to 1.5.1, given time, if it can be fixed in a safe way. Retargetting to 2.0 because ran out of time. I kind of remember the fix involved calculating font size. Comment on attachment 41799 [details]
org.eclipse.wst.dtd.ui.patch
obsoleting patch since this one was already applied and this bug is still open because it needs additional fixing
Created attachment 61176 [details] org.eclipse.wst.dtd.ui.patch I found a better solution than calculating font metrics and whatnot. Just basically call something like this: >> Point p = cLabel.computeSize(SWT.DEFAULT, SWT.DEFAULT, false); >> int labelWidth = Math.max(p.x, 98); FormData data = new FormData(labelWidth, SWT.DEFAULT); data.left = new FormAttachment(0, 0); data.top = new FormAttachment(0, 0); cLabel.setLayoutData(data); computeSize will be more accurate in computing estimated size (instead of guessing average font size) fixed & released for wtp 2.0 m6. |