Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 140758

Summary: [junit] Inconsistent labels in JUnit view
Product: [Eclipse Project] JDT Reporter: Martin Aeschlimann <martinae>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, darin.eclipse, markus.kell.r, philippe_mulet
Version: 3.2   
Target Milestone: 3.2 RC4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Fix
none
Fix 2
none
Simpler with less code duplication none

Description Martin Aeschlimann CLA 2006-05-09 05:37:28 EDT 
RC3

From bug 140125, the last remaining issues releated to labels that should be fixed for consistency and to avoid confusion.

- Show test kind also to top node of hierarchy
- Show number of ignored test count in header

- Rename 'Show Test Hierarchy' to 'Show Tests in Hierarchy'
(or change to two items 'Show as List', 'Show as Tree' if this is a trivial change)

- Capitalization tooltips and vew menu action labels
   'Show Failures only' -> 'Show Failures Only'
   'Activate on Error/Warning only' -> 'Activate on Error/Warning Only'

- In launch configuration change the label 'Test Loader:' to 'Test runner:'
Comment 1 Markus Keller CLA 2006-05-09 12:51:24 EDT 
Created attachment 40757 [details]
Fix

Patch fixes all items except for:
- Show number of ignored test count in header

That one is better fixed with bug 140551, since it requires the same changes to access the ignored state.
Comment 2 Martin Aeschlimann CLA 2006-05-10 04:50:54 EDT 
Agree on comment 1. Otherwise the two patches get a dependency. Let's keep it simple.
Note, patch should use 'Test runner:' not 'Test Runner:'
Comment 3 Markus Keller CLA 2006-05-10 05:19:48 EDT 
Created attachment 40913 [details]
Fix 2

Fixes 'Runner -> runner' as well.
Comment 4 Martin Aeschlimann CLA 2006-05-10 12:10:02 EDT 
+1 for 3.2 RC4

Darin and Philippe, do you support these changes?

The fix is low risk. Only minor label changes with the exception of adding the runner kind name to the top hierarchy node: This saves the user some trouble when launching with the wrong test kind (JUnit 3 / JUnit 4): Then you might only get a subset of tests ran instead of all, but it isn't clear why. See bug 140553.
Comment 5 Philipe Mulet CLA 2006-05-10 12:48:40 EDT 
+1 for 3.2RC4
Comment 6 Dani Megert CLA 2006-05-10 14:40:47 EDT 
Created attachment 40996 [details]
Simpler with less code duplication

Approving the fix for 3.2 RC4. You can either release your patch or consider my suggested simpler version which removes code duplication and also replaces three casts into a local variable.
Comment 7 Martin Aeschlimann CLA 2006-05-11 06:45:30 EDT 
released Dani's patch > 20060511
Comment 8 Markus Keller CLA 2006-05-11 07:40:03 EDT 
Changed label addition in tooltip and for first element in tree from [JUnit 4] to [Runner: JUnit 4].
Comment 9 Johannes Rieken CLA 2006-05-11 10:35:05 EDT 
verifying for N20060511-0010
Comment 10 Johannes Rieken CLA 2006-05-11 10:47:59 EDT 
verified for I20060511-0800 (not for N20060511-0010)