Bugzilla – Full Text Bug Listing
| Summary: | Allow programmatic context for initially selected project in Generic Recorder Wizard | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Jeff Nevicosi <nevicosi> | ||||
| Component: | TPTP | Assignee: | Paul Slauenwhite <paulslau> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P1 | CC: | jkubasta, paulslau | ||||
| Version: | unspecified | Keywords: | plan | ||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 208110 | ||||||
| Attachments: |
|
||||||
|
Description
Jeff Nevicosi
Must defer to 4.3, since this requires changing/breaking API. reassigning to new Generic Recorder Framework owner. Jerome, please reassign if this isn't your area. Thanks. Add estimate. Targeting to future since not containable in 4.4. As discussed on this week's Test Project call (January 22, 2007), the Test Project will focus on existing P1 - P2/Blocker - Major and P1/Normal and test creation/automation defects (omitting defects dependant on outstanding features) in TPTP 4.4. All other Test Project defects have been targeted to future. If this defect has been targeted to future and you/originator feel it should be completed in 4.4, please provide the necessary reason as a reply to this comment or a post to the Test Project mailing list (tptp-test-tooling-dev@eclipse.org). We will collectively triage and assess our resources to determine a case-by-case decision. As discussed on this week's Test Project call (January 22, 2007), the Test Project will focus on existing P1 - P2/Blocker - Major and P1/Normal and test creation/automation defects (omitting defects dependant on outstanding features) in TPTP 4.4. All other Test Project defects have been targeted to future. If this defect has been targeted to future and you/originator feel it should be completed in 4.4, please provide the necessary reason as a reply to this comment or a post to the Test Project mailing list (tptp-test-tooling-dev@eclipse.org). We will collectively triage and assess our resources to determine a case-by-case decision. Correction: The Test Project mailing list is tptp-testing-tools-dev@eclipse.org. Since there are no Test project types in TPTP, this defect is only for selecting the context-sensitive project in the location page used to launch the GRF wizard. Duwayne, please provide a sizing. Bulk update of the target field to reflect the change in iteration numbers. I will handle this with enhancement 208110. Jeff, are you looking for something more than the user selecting a project in a navigator/explorer and have that select made available to the subsequent GRF wizard pages? (In reply to comment #12) > Jeff, are you looking for something more than the user selecting a project in a > navigator/explorer and have that select made available to the subsequent GRF > wizard pages? > I am also assumming you are only referring to the default org.eclipse.tptp.test.provisional.recorder.ui.wizards.TestsuiteLocationWizardPage.java page of the GRF wizard. Extenders may determine the selection by calling org.eclipse.tptp.test.internal.recorder.ui.wizards.NewTestFromRecordingWizard#getSelection(). It wasn't the intention of this defect to preselect based on Navigator context (although that's a good idea). Extending project has an additional wizard (let's call it NewTestProjectWizard) 1) NewTestProjectWizard creates a project with a user-specified name. 2) Upon successful completion, NewTestProjectWizard then launches NewTestFromRecordingWizard The intention is to preselect the testsuite container to the project which was just created. One design thought is to create another constructor NewTestProjectWizard(IContainer). Another (by Paul), was to use HyadesWizard.getSelection() & add support for this to IGenericRecordingWizardPage The original thought was for this only to be used by the default page: TestsuiteLocationWizardPage. However, a simple API could be made available (e.g. NewTestFromRecordingWizard.getDefaultContainer() ), which could be used by all extenders. The following files checked-in to CVS (HEAD): I am assuming you meant NewTestFromRecordingWizard (IContainer) and not NewTestProjectWizard(IContainer). Created attachment 92450 [details]
Patch
This patch fixes two issues: 1) The GRF was not providing the selection in the active workbench window to the wizard pages. Added org.eclipse.tptp.test.provisional.recorder.ui.wizards.IRecorderPageProvider.WIZARD_KEY_INITIAL_STRUCTURED_SELECTION that allows IGenericRecorderWizard implementations to provide IStructuredSelections to its wizard pages by calling the IGenericRecorderWizard#getRecorderObjectData(IRecorderPageProvider.WIZARD_KEY_INITIAL_STRUCTURED_SELECTION) method. In addition, the org.eclipse.tptp.test.internal.recorder.ui.wizards.NewTestFromRecordingWizard.java was updated to retrieve the selection from the super class (org.eclipse.hyades.ui.internal.wizard.HyadesWizard.getSelection()). 2) When programmatically instantiating the org.eclipse.tptp.test.internal.recorder.ui.wizards.NewTestFromRecordingWizard.java, calling the org.eclipse.hyades.ui.internal.wizard.HyadesWizard.init(IWorkbench, IStructuredSelection) method had no effect since the IStructuredSelection was not respected. For example, org.eclipse.hyades.internal.execution.recorder.ui.actions.NewGenericRecordingAction.run(). Now, the GRF provides the the selection in the active workbench window to the default wizard pages. Patch checked in to CVS (HEAD). verified. closed. |