Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 139181

Summary: [ltk] AFE in MultiStateTextFileChange.getCurrentContent [refactoring]
Product: [Eclipse Project] JDT Reporter: Benno Baumgartner <benno.baumgartner>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: markus.kell.r, martinae
Version: 3.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: stalebug

Description Benno Baumgartner CLA 2006-04-28 10:46:55 EDT
N20060428

- Use 'Clean up' on the ast view source (org.eclipse.jdt.astview)
- 'Select all' clean ups, press 'next'
- On 'ASTLabelProvider' select 'Change 'if' statement body to block'
- Dialog shows up 'An error has occurred'

org.eclipse.core.runtime.AssertionFailedException: assertion failed: 
        at org.eclipse.core.runtime.Assert.isTrue(Assert.java:109)
        at org.eclipse.core.runtime.Assert.isTrue(Assert.java:95)
        at
org.eclipse.ltk.core.refactoring.MultiStateTextFileChange.getCurrentContent(MultiStateTextFileChange.java:398)
        at
org.eclipse.ltk.internal.ui.refactoring.TextEditChangePreviewViewer.setInput(TextEditChangePreviewViewer.java:180)
        at
org.eclipse.ltk.internal.ui.refactoring.TextEditGroupNode.feedInput(TextEditGroupNode.java:76)
        at
org.eclipse.ltk.internal.ui.refactoring.PreviewWizardPage.showPreview(PreviewWizardPage.java:519)
        at
org.eclipse.ltk.internal.ui.refactoring.PreviewWizardPage.access$3(PreviewWizardPage.java:498)
        at
org.eclipse.ltk.internal.ui.refactoring.PreviewWizardPage$3.selectionChanged(PreviewWizardPage.java:489)
        at org.eclipse.jface.viewers.Viewer$2.run(Viewer.java:162)
        at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
        at org.eclipse.core.runtime.Platform.run(Platform.java:816)
        at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:44)
        at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:149)
        at
org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java:160)
        at
org.eclipse.jface.viewers.StructuredViewer.updateSelection(StructuredViewer.java:1922)
        at
org.eclipse.jface.viewers.StructuredViewer.handleSelect(StructuredViewer.java:1099)
        at
org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect(CheckboxTreeViewer.java:271)
        at
org.eclipse.jface.viewers.StructuredViewer$4.widgetSelected(StructuredViewer.java:1125)
        at
org.eclipse.jface.util.OpenStrategy.fireSelectionEvent(OpenStrategy.java:213)
        at org.eclipse.jface.util.OpenStrategy.access$3(OpenStrategy.java:207)
        at
org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:374)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:925)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3340)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2960)
        at org.eclipse.jface.window.Window.runEventLoop(Window.java:820)
        at org.eclipse.jface.window.Window.open(Window.java:796)
        at
org.eclipse.ltk.ui.refactoring.RefactoringWizardOpenOperation$1.run(RefactoringWizardOpenOperation.java:132)
        at
org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69)
        at
org.eclipse.ltk.ui.refactoring.RefactoringWizardOpenOperation.run(RefactoringWizardOpenOperation.java:145)
        at
org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate(RefactoringStarter.java:40)
        at
org.eclipse.jdt.internal.ui.actions.CleanUpAction.runOnMultiple(CleanUpAction.java:227)
        at
org.eclipse.jdt.internal.ui.actions.CleanUpAction.run(CleanUpAction.java:96)
        at
org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun(SelectionDispatchAction.java:267)
        at
org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(SelectionDispatchAction.java:243)
        at org.eclipse.jface.action.Action.runWithEvent(Action.java:499)
        at
org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:539)
Comment 1 Markus Keller CLA 2006-05-02 13:36:49 EDT
Tobias, is this the same problem as bug 131495?

Can we fix this or work around it for RC3 (either on the UI side or by not reusing ASTRewrites)+?

Comment 2 Tobias Widmer CLA 2006-05-03 03:24:00 EDT
No, this is another defect caused by the implementation of the preview for a MultiStateTextFileChange. Only the preview of single change nodes in the preview viewer is affected.
A fix would require some more investigation and testing, since the refactoring preview generation is non-trivial.
Comment 3 Markus Keller CLA 2006-05-03 06:02:33 EDT
OK, not for 3.2 then.
Comment 4 Martin Aeschlimann CLA 2008-05-07 09:38:49 EDT
Benno, what's the state here? I couldn't reproduce the problem: The ASTViewLabelProvider doesn't has any children anymore.
Comment 5 Benno Baumgartner CLA 2008-05-07 11:25:54 EDT
(In reply to comment #4)
> Benno, what's the state here? I couldn't reproduce the problem: The
> ASTViewLabelProvider doesn't has any children anymore.
> 

Yes, this feature has been removed some time ago by bug 157798. MSTFC don't have any change groups anymore in clean up preview. 
Comment 6 Eclipse Genie CLA 2019-11-25 16:33:56 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.