Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 139141

Summary: Breakpoint image in ruler not updated if breakpoint enablement is toggled
Product: [WebTools] WTP Source Editing Reporter: Nitin Dahyabhai <thatnitind>
Component: wst.sseAssignee: Nitin Dahyabhai <thatnitind>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, david_williams
Version: 1.5   
Target Milestone: 1.5 RC3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch for org.eclipse.wst.sse.ui none

Description Nitin Dahyabhai CLA 2006-04-28 09:38:41 EDT 
1.5 I200604272112 build

Disabled breakpoints are showing the same image as enabled breakpoints.  It doesn't matter if the breakpoint was disabled in the Breakpoints view or in the editor itself.  The correct image is used if the breakpoint is disabled before the editor is opened, but doesn't switch to the enabled image unless the editor is restarted.
Comment 1 Dani Megert CLA 2006-05-17 05:43:07 EDT 
Might be related to bug 142170.
Comment 2 Nitin Dahyabhai CLA 2006-05-18 03:25:14 EDT 
Created attachment 41850 [details]
patch for org.eclipse.wst.sse.ui

Regrettably, not the same thing.  Turns out we were creating our own annotation type for breakpoint markers and they weren't updating properly on property changes.  Simplest thing to do is remove all of that so that we only have custom annotation types for problem markers.  The presentation of the breakpoints was virtually identical otherwise, always using the defaults, so the only reason I can find that we had that code was to workaround a bug (bug 32469) that has long since been fixed.

David please review for RC3/4.
Comment 3 Nitin Dahyabhai CLA 2006-05-18 03:25:44 EDT 
CCing David for review.
Comment 4 David Williams CLA 2006-05-18 03:32:53 EDT 
removing code == good. 

Just to double check ... will this effect any of our clients (e.g. Sam?) that might not be tied in to our day to day WTP changes? 

But, otherwise approved. 

Thanks.
Comment 5 Nitin Dahyabhai CLA 2006-05-18 09:23:42 EDT 
It should have no other effect.  Our annotation model is still handling the support for external breakpoints as before, just not making custom annotations for them.
Comment 6 Nitin Dahyabhai CLA 2006-05-18 14:47:27 EDT 
Committing for RC3 respin
Comment 7 Nitin Dahyabhai CLA 2006-06-21 17:37:22 EDT 
Verified in WTP 1.5 RC5a
Comment 8 Nitin Dahyabhai CLA 2006-06-29 14:27:49 EDT 
Closing