Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 139126

Summary:	Bundle name of custom figure is not added to the plugin dependencies of diagram editor
Product:	[Modeling] GMF-Tooling	Reporter:	Dmitry Stadnik <dimzzy>
Component:	Core	Assignee:	Artem Tikhomirov <tikhomirov.artem>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ahunter.eclipse, boris.blajer, lava20002001, lding, richard.gronback, tikhomirov.artem
Version:	unspecified
Target Milestone:	2.1
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	154842

Description Dmitry Stadnik

2006-04-28 09:15:18 EDT

- Define custom figure in gmfgraph model
- Specify custom bundle name
- Generate gmfmap and diagram editor
=> Compilation error; custom figure bundle is not referenced

Hint: try ScalableImageFigure for example

Comment 1 Artem Tikhomirov

2006-05-02 11:57:48 EDT

Use FigureGallery#implementationBundle instead of CustomClass#bundleName. Latter should be removed from the model.

Comment 2 Michael Golubev

2006-05-02 12:01:27 EDT

According to Artem's proposal, Bundle property for CustomFigure considered as deprecated now and will be removed soon.

According to this proposal, the only correct way to describe custom figure implemented in the bundle "com.mycompany" is to create different FigureGallery for this bundle, set gallery's bundle property and than create CustomFigure in this new gallery.

So the only fix possible for this bug is to delete the CustomFigure#bundle property.

Comment 3 Boris Blajer

2006-05-04 09:43:41 EDT

A similar problem exists if a custom layout is used. It should be possible to specify the bundle where the custom layout resides. FigureGallery#implementationBundle may not be enough if, e.g., only Rectangle figures are grouped using a non-standard layout. In this case, it makes little sense to say that this figure gallery has the implementation bundle of the plugin where the custom layout resides (besides, several custom layouts may be used, and they may come from different, unrelated plugins).

Comment 4 Richard Gronback

2007-03-01 10:55:45 EST

Updated target milestone

Comment 5 Anthony Hunter

2007-05-01 09:22:18 EDT

Since GMF 2.0 M6 was released April 5, 2007, doing a bulk move of all open Bugzillas currently on M6 to 2.0 M7. Owners will need to access if the issue really is targetted for 2.0 M7.

Comment 6 Artem Tikhomirov

2007-06-18 09:45:31 EDT

Need to address implementation bundle issue for custom borders and layouts.

Comment 7 Artem Tikhomirov

2007-06-18 09:49:27 EDT

*** Bug 154842 has been marked as a duplicate of this bug. ***

Comment 8 Artem Tikhomirov

2008-05-21 13:19:00 EDT

(In reply to comment #6)
> Need to address implementation bundle issue for custom borders and layouts.

Borders and layouts can be reused/referenced with BorderRef and LayoutRef respectively. With that, custom borders and layouts could be described within their distinct FigureGalleries (along with proper implementationBundle) and later reused in figures belonging to other FigureGalleries. All respective implementationBundle entries would get into viewmap's requiredPlugins attribute and eventually into dependencies of generated diagram editor.

Comment 9 Eclipse Webmaster

2010-07-19 12:19:00 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Templates was the original product and component for this bug