Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 138626

Summary: ConcurrentModificationException in AbstractEditPartViewer.fireSelectionChanged()
Product: [Tools] GEF Reporter: Cherie Revells <crevells>
Component: GEF-Legacy GEF (MVC)Assignee: Cherie Revells <crevells>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: hudsonr, nyssen
Version: 3.2   
Target Milestone: 3.2.0 (Callisto) RC2   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Attachments:
Description Flags
Patch for AbstractEditPartViewer nyssen: iplog+

Description Cherie Revells CLA 2006-04-26 09:58:41 EDT
This is a duplicate of Bugzilla#31789.  The fix for this bug was never propogated from the R_2_1_2_Maintenance branch to head in CVS.
Comment 1 Cherie Revells CLA 2006-04-26 11:47:51 EDT
Created attachment 39543 [details]
Patch for AbstractEditPartViewer

Here is a patch.  I looked at what had been in the R_2_1_2_Maintenance branch.  I ran the basic GEF tests (not the performance tests). 12/12 passed.
Comment 2 Steven R. Shaw CLA 2006-04-26 13:38:07 EDT
+1 for RC2
Comment 3 Randy Hudson CLA 2006-04-26 13:51:49 EDT
Hopefully there is no client relying on the current ability to append listeners mid-firing (and have them receive that notification).

I reopened bug 31789, so that the original reporters would know about the regression.

+1, we should close both bugs.
Comment 4 Steven R. Shaw CLA 2006-04-26 15:50:27 EDT
Committed patch