Bugzilla – Full Text Bug Listing
| Summary: | [Markers] problems view quick fix of multiple identical warnings does not work | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Peter Larsen <peblpebl> |
| Component: | IDE | Assignee: | Tod Creasey <Tod_Creasey> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | minor | ||
| Priority: | P3 | CC: | eclipse, remy.suen |
| Version: | 3.1 | Keywords: | helpwanted |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
|
Description
Peter Larsen
You can you give an example of a fixes that should be the same? If we are not finding matching problems a bug needs to be logged to JDT with an example to see if they can do it. *** This bug has been marked as a duplicate of 124614 *** Here is the example that does not work
Test example of identical problems but not found under "find similar problems".
(The declared exception IOException is not actually thrown by the method
sameproblem1() ...)
import java.io.IOException;
public class EclipseIdenticalBugs {
public void sameproblem1() throws IOException {}
public void sameproblem2() throws IOException {}
}
I've got the same behaviour here with 3.4M5 - both in JDT and PDE environments. For example, I just checked out the EMF sources and got tons of "Plug-ins declaring extensions or extension points must set the singleton directive to true" messages. I can select all of them and issue "Quick Fix" in the problems view, but the resulting dialog only resolves one of the issues and leaves the other ones untouched. Do I have to mention that it's rather annoying to "right click - Cmd-1 - Enter" through 50-odd errors? ;-) If you have multiple strings that haven't been externalized and you try to invoke quick fix on them, they do all show up on the dialog. However, in an alternate scenario like multiple private fields that aren't being used, invoking quick fix will present the user with three different resolutions. Only in the field removal resolution are all the selections displayed. The other resolutions will only show the first selection. Tod, do you think this is a JDT problem? The "find simular problems" is gone since I reported this bug. But I get same behaviour as comment #3. Another test case: public class UnnecessarySemicolon { public void semi1() {/**/}; public void semi2() {/**/}; } Marking both problems view will bring up a dialog suggesting to solved only the _first_ marked. (change the sorting and the other is shown). No this is a problem with the fact that applying a fix usually changes line numbers so JDT can only multi apply the NL fix. I have removed the multi-select enable in M6 because this is confusing people. See Bug 212599 Just to make sure I get this right - you're talking about JDT only. Is there a chance that other parts of Eclipse - like PDE - implement something like a "mass quick fixer"? For a motivation see comment #3 - it is really annoying to fix this manually after checking out tons of plug-ins. Should I open a new bug in PDE to ask for this? No - we are talking about any fix where the contents would change as a result of the fix so it could happen anywhere. I too would say that it is really annoying to correct 100+ of
Unnecessary Semicolon warnings one by one.
I still do not grasp why
>>
No this is a problem with the fact that applying a fix usually changes line
numbers so JDT can only multi apply the NL fix.
<<
is valid. Does removing semicolons change the line numbers.
Why not correct the fixes in reverse starting from highest line number?
|