Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 138547

Summary:

CorrectionMarkerResolutionGenerator has inconsistent hasResolutions and getResolutions

Product:

[Eclipse Project] JDT

Reporter:

Tod Creasey <Tod_Creasey>

Component:

Assignee:

JDT-UI-Inbox <jdt-ui-inbox>

Status:

RESOLVED WONTFIX

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert

Version:

3.2

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

138404

Attachments:

Description	Flags
java file with this issue	none

Description Tod Creasey

2006-04-25 21:50:04 EDT

20060425

The file i am about to attach has an unreachable code error. The CorrectionMarkerResolutionGenerator returns true for #hasResolutions and an empty collection for #getResolutions. As a result we are getting an empty Quick Fix dialog.

Comment 1 Tod Creasey

2006-04-25 21:50:54 EDT

Created attachment 39500 [details]
java file with this issue

Comment 2 Martin Aeschlimann

2006-04-27 09:03:38 EDT

By design 'hasResolutions' provides only a good guess. Computing the actual proposals is expensive and can't be done while opening a context menu (or lightbulb drawing in the editor). The Quick Fix dialog should be prepared for this.

Obviously in this scenario the quick fix should work. I fixed this > 20060427

Closing the bug as WONTFIX.

Comment 3 Martin Aeschlimann

2007-12-13 05:41:38 EST

*** Bug 212836 has been marked as a duplicate of this bug. ***

Comment 4 Tod Creasey

2008-01-17 15:07:12 EST

*** Bug 207837 has been marked as a duplicate of this bug. ***