Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 138503

Summary: [KeyBindings] Restore button in Preferences Keybings page not useful
Product: [Eclipse Project] Platform Reporter: Duong Nguyen <duongn>
Component: UIAssignee: Paul Webster <pwebster>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: markus.kell.r
Version: 3.2   
Target Milestone: 3.3   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Bug Depends on: 176235    
Bug Blocks:    

Description Duong Nguyen CLA 2006-04-25 16:54:21 EDT 
I'm confused about how the "Restore" button is supposed to work in the Preferences keybindings page. After I added a new keysequence (eg. Ctrl-D to Copy) and pressed Apply, and then I press Remove to remove (Ctrl-D), I would expect pressing "Restore" to bring it back.

In another case, I selected Copy and removed the Ctrl-C entry. I closed the Preference page and came back-in to edit the same Copy entry, pressing "Restore" didn't bring it back. To restore it, I had to press Ctrl-C in the key sequence name and then pressed "Restore". What's the point of having "Restore" when I have to know exactly what the key sequence was and when it is used?

Expected: "Restore" to be the same as "Restore Defaults" (which resets all key bindings) but is localized to the current command only.
Comment 1 Markus Keller CLA 2006-07-28 10:35:38 EDT 
In 3.0, when a predefined key binding was removed, a disabled entry was still there. The user could choose a command and the selectively restore manually deleted bindings.

In 3.1 and later, removed bindings are not shown any more, and users have no way to restore the removed bindings for a command...
Comment 2 Paul Webster CLA 2006-09-28 15:17:48 EDT 
Is this still a problem in 3.3?

PW
Comment 3 Markus Keller CLA 2006-09-29 10:30:35 EDT 
Yes. It looks like the Restore button only applies to a selected shortcut now (partially restores the default binding).
Still missing:
- can't see default shortcuts per command
- can't restore default shortcuts per command
- can't see/restore all bindings for a shortcut (e.g. when I remove both bindings for Ctrl+W, the Restore button only restores one of the two).
Comment 4 Paul Webster CLA 2007-06-21 15:03:31 EDT 
Fixed with the new keys page
PW