Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 138472

Summary: Spell checking errors in SSE do not have content assist or quick fix help like the Java editor
Product: [WebTools] WTP Source Editing Reporter: Lawrence Mandel <lmandel>
Component: wst.sseAssignee: Amy Wu <for.work.things>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: for.work.things, Michael.Valenta, thatnitind
Version: 1.5   
Target Milestone: 2.0 RC0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 170988    
Bug Blocks:    

Description Lawrence Mandel CLA 2006-04-25 15:11:25 EDT
I was trying out spell checking in the XML editor. When a spelling error was identified the editor did not provide any way to tell what the correct spelling should be or to add the word to the dictionary. The same text in a Java comment has these options
Comment 1 Nitin Dahyabhai CLA 2006-05-04 11:47:13 EDT
The proposals in the Java editor ans Java source sections come from the Java content assist engine.  While the Spelling problems reported by the spelling engine *can* contain suggested corrections, they don't.  Additionally, SSE doesn't yet have a consistent QuickFix implementation.
Comment 2 Nitin Dahyabhai CLA 2006-05-08 23:45:59 EDT
*** Bug 140628 has been marked as a duplicate of this bug. ***
Comment 3 Amy Wu CLA 2007-04-16 17:15:03 EDT
The fix for this should be included in the fix for bug 170988.
Comment 4 Amy Wu CLA 2007-04-16 17:15:31 EDT
fixed in wtp 2.0 rc0
Comment 5 Lawrence Mandel CLA 2008-06-15 01:06:22 EDT
Amy, I may be missing something but I don't see the fix for this bug in WTP 3.0 RC4. I created a simple XML document as shown below

<root>
weclome
</root>

The word welcome is misspelled as weclome. The editor correctly hilites the word but still does not provide a quick fix solution.
Comment 6 Nitin Dahyabhai CLA 2008-06-16 10:28:03 EDT
Lawrence, on the Text Editors Spelling preference page, which dictionary do you have selected?
Comment 7 Lawrence Mandel CLA 2008-06-16 11:24:45 EDT
English (United States)
Comment 8 Amy Wu CLA 2008-06-16 11:29:04 EDT
The scenario worked for me on a recent WTP 3.0 RC4 build.
Are you getting any other quick fix proposals?  Like
<root bad>
weclome
</root>

Quick fix proposals for the "bad" attribute?  How are you invoking quick fix?
Comment 9 Lawrence Mandel CLA 2008-06-16 11:53:42 EDT
I just tried the bad attribute example and didn't get a quick fix proposal for that either. 

One potential configuration difference, I only have wst installed. Do I need jst to get the quick fix proposals?
Comment 10 Lawrence Mandel CLA 2008-06-16 12:10:53 EDT
After speaking with Amy I see that quick fixes are working the problem was a user error. I thought quick fixes were not working because I didn't see a light bulb icon. Quick fix is working with ctrl+1. I've opened bug 237301 to address the light bulb issue.
Comment 11 Lawrence Mandel CLA 2008-06-16 12:11:18 EDT
Verified on WTP 3.0 RC4.