Bugzilla – Full Text Bug Listing
| Summary: | wsimsg editor is exactly the same as xml editor (except for icon) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Webservices | Reporter: | Amy Wu <for.work.things> | ||||||
| Component: | wst.wsi | Assignee: | Lawrence Mandel <lmandel> | ||||||
| Status: | CLOSED FIXED | QA Contact: | David Lauzon <lauzond> | ||||||
| Severity: | major | ||||||||
| Priority: | P3 | CC: | thatnitind | ||||||
| Version: | 1.5 | ||||||||
| Target Milestone: | 1.5.1 M151 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Increasing severity. On GTK, you can't see a default checkbox on the menu at the same time as an image. It becomes impossible to tell the two apart, and the action sets would at least be missing from the WSI Log viewer. Created attachment 42051 [details]
Open With... submenu on Linux-GTK
Created attachment 43841 [details]
patch to change editor name
I'll take this one. Nitin - Is this a must fix for 1.5 or are you comfortable defferring to 1.5.1? I would like it fixed, but we are running late to change strings as I understand it. It can be deferred if needed. I'm defferring to 1.5.1. I created two separate fixes for this bug. For 1.5.1 I used Nitin's patch (thanks Nitin!) and updated the name of the WS-I log viewer. For 2.0 I've removed the declaration of the WS-I log viewer as it was simply a redeclaration of the XML editor and was adding clutter to the UI. The WS-I log viewer can be added back if and when a distinct editor is created for the logs. Fixes released on 20060814. -verified in wtp 1.5.1 9/14/06 build that there is a separate name for wsimsg editor -verified in wtp 2.0 8/31/06 build that there is no longer a wsimsg editor -verified in both wtp builds that wsimsg files open in xml editor. |
The wsimisg editor defined in the wsi.ui plugin.xml looks like it is exactly the XML editor. The only difference appears to be the icon. There are no additional actions or anything. *.wsimsg is XML content type. As long as *wsimsg is XML Content type, the XML editor will open for it. I don't think there's really a need for a separate editor definition. It will just add to editor clutter. Fix would be to remove the editor definition: <!-- ======================================================= --> <!-- Extension point: org.eclipse.ui.editors --> <!-- Purpose: Specify editor for file with extension wsimsg. --> <!-- ======================================================= --> <extension point="org.eclipse.ui.editors"> <editor name="%_UI_LOG_EDITOR" extensions="wsimsg" icon="icons/wsi_logfile_obj.gif" class="org.eclipse.wst.xml.ui.internal.tabletree.XMLMultiPageEditorPart" id="org.eclipse.wst.wsi.ui.internal.WSILogEditor"> </editor> </extension>