Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 136759

Summary: Project/EAR messages are missing from project selection widget
Product: [WebTools] WTP Webservices Reporter: Rupam Kuehner <rsinha>
Component: jst.wsAssignee: Joan Haggarty <joan>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 1.5   
Target Milestone: 1.5 M6   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Bug Depends on: 136712    
Bug Blocks:    

Description Rupam Kuehner CLA 2006-04-13 17:25:03 EDT
In the old page 3 we used to have little messages in under the EAR field that said things like:

The selected {0} project will be associated with the EAR project.
The {0} project will be created and associated with the EAR project.
The {0} EAR project will be created and associated with the project.
The {0} project and EAR project will be created and associated with one another.

These messages no longer display anywhere. 
The code to figure out the message content is still there in ProjectSelectionWidget.handleSetMessageText but it's just not being called anymore. I'm not sure if the messages should be displayed in the project dialog or on page 1 (and if on page 1, where on page 1's limited space?)

Perhaps we should remove them altogether since I'm not sure how helpful they are.

I'm opening this bug so that we don't forget about them.
Comment 1 Chris Brealey CLA 2006-04-14 10:10:46 EDT
These messages should go in the text areas (to the right of the graphics) that contain the hyperlinks. These areas were originally meant to contain prose text - such as the now missing messages - with embedded hyperlinks. The catch is we haven't figured out how, or if, we can mix regular and hyperlink text, and without doing this there may not be enough room in the text areas.

The project dialog is a reasonable spot for the messages since that's where the user will actually monkey with the values. The wizard banner is another.
Comment 2 Rupam Kuehner CLA 2006-04-18 09:36:16 EDT
We should only have one message in the wizard banner at a time (error, warning, or info) per Kate's guidelines. If we went with the banner as the location we should only display these "info" messages when there are no errors or warnings on the page.
Comment 3 Joan Haggarty CLA 2006-04-18 16:43:20 EDT
I've added code to the new SimpleDialog framework that now calls getStatus() appropriately within the dialogs.  There is now a message area at the bottom of the dialog above the buttons that displays messages and the OK button is enabled and disabled based on the status returned by getStatus (disabled for IStatus.ERROR).

The fix for 136335 will cover this.

I notice though that the message area doesn't seem to get repainted properly when new text is written to it.  I'm going to use this bug for that problem.  I'm currently investigating.
Comment 4 Joan Haggarty CLA 2006-04-18 17:41:33 EDT
look for combined patch in 136712
Comment 5 Kathy Chan CLA 2006-04-18 22:52:34 EDT
Patch reviewed and committed.  Will release later.
Comment 6 Kathy Chan CLA 2006-04-18 23:46:10 EDT
Released to WTP 1.5 as v200604190331.
Comment 7 Rupam Kuehner CLA 2006-05-16 17:42:42 EDT
Verified.
Comment 8 Joan Haggarty CLA 2006-05-17 08:45:12 EDT
Closing.