Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 136244

Summary:	[Dialogs] PopupDialog - API - overriding default colors should be simpler
Product:	[Eclipse Project] Platform	Reporter:	Susan McCourt <susan>
Component:	UI	Assignee:	Susan McCourt <susan>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P5
Version:	3.2
Target Milestone:	3.4 M6
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Susan McCourt

2006-04-11 22:49:23 EDT

PopupDialog has protected methods that allow you to dictate which controls in the dialog should have their foreground/background color set.  However, it is not simple to override the colors themselves.

The method applyColors is private, and in order to use applyForegroundColor(...), etc., you must override createContents to ensure that the subclasses' colors get set after the default colors.

Instead, the method applyColors should either be made protected, or it should call protected methods that specify the foreground and background color, rather than assuming it is always the system info colors.

Comment 1 Susan McCourt

2006-04-11 22:51:56 EDT

when this is fixed, clean up the overrides in ContentProposalAdapter$ContentProposalPopup.

Comment 2 Susan McCourt

2007-04-03 12:12:21 EDT

This would require API change (protected methods in public class), so can't be done at this point.  Adding API to title so this is clearer.

Comment 3 Susan McCourt

2007-07-01 10:39:37 EDT

This message is part of a mass update...the bug is likely legitimate, but not a priority. Marking P5.  Patches would be entertained.

Comment 4 Susan McCourt

2008-03-20 13:22:19 EDT

will fix this while addressing bug #133731

Comment 5 Susan McCourt

2008-03-20 14:56:16 EDT

Fixed in HEAD.

Comment 6 Susan McCourt

2008-03-25 12:32:36 EDT

verified in I20080324-1800 via source inspection.  The new API is used by the content assist popups to override the defaults and consult the content assist color preferences.