Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 136119

Summary: [Help] Find a way to add ICU4J to webapp
Product: [Eclipse Project] Platform Reporter: Curtis d'Entremont <curtispd>
Component: User AssistanceAssignee: platform-ua-inbox <platform-ua-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: cgold
Version: 3.2   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
the patch with webapp changes none

Description Curtis d'Entremont CLA 2006-04-11 11:17:36 EDT 
This is related to the org.eclipse.help.webapp patch from bug 135781. The build failed because it is compiling the webapp from an ant task, so importing the ICU4J package would not work in this case.

We cannot do a package import from an ant task unless we write a whole bunch of code that mimics what the PDE/OSGi runtime do for finding the plugin that contains that package.

I don't think we can simply import the com.ibm.icu plugin because it may not exist at runtime; products who don't want the full weight of icu can swap out another plugin with the same interfaces that simply forwards all the calls to the JRE classes.

Because there is only a single change for ICU, we can release without it for 3.2 and find a safe way to use it in the next release.
Comment 1 Curtis d'Entremont CLA 2006-04-11 11:18:47 EDT 
Created attachment 38289 [details]
the patch with webapp changes
Comment 2 Chris Goldthorpe CLA 2007-06-12 18:49:50 EDT 
Curtis, does this bug still apply?
Comment 3 Curtis d'Entremont CLA 2007-06-12 18:55:44 EDT 
Yes, but it's not urgent. The patch is probably stale because we switched from an ant build.xml to a builder for the web app. But hopefully it should be easier now to integrate ICU4J.
Comment 4 Chris Goldthorpe CLA 2009-05-20 17:10:48 EDT 
I think this bug no longer applies because the help system now imports com.ibm.icu.text, this was required to get the index to display in a reasonable order in languages which have accented characters.