Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 135565

Summary: [CommonNavigator][Java] Patch for various issues in the Java extension
Product: [Eclipse Project] JDT Reporter: Michael D. Elder <mdelder>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: vtrivedi
Version: 3.2   
Target Milestone: 3.2 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
The CN Extension update none

Description Michael D. Elder CLA 2006-04-07 11:05:40 EDT
This patch provides:

(1) Improved Open Action Provider
(2) Menu options: Open Type Hierarchy
(3) Slight modifications to OpenViewActionGroup to hide properties action from Java extension (already contributed by Resource extension)
(4) Integration with Intercept framework for Add/Remove
(5) Common Wizard definition 
(6) References/Declarations search menu options
Comment 1 Michael D. Elder CLA 2006-04-07 11:06:36 EDT
Created attachment 37998 [details]
The CN Extension update
Comment 2 Michael D. Elder CLA 2006-04-07 11:07:03 EDT
Reassigning to Markus for evaluation and release.
Comment 3 Michael D. Elder CLA 2006-04-07 11:08:15 EDT
*** Bug 102024 has been marked as a duplicate of this bug. ***
Comment 4 Michael D. Elder CLA 2006-04-07 11:12:17 EDT
*** Bug 131469 has been marked as a duplicate of this bug. ***
Comment 5 Michael D. Elder CLA 2006-04-07 11:14:07 EDT
*** Bug 131939 has been marked as a duplicate of this bug. ***
Comment 6 Michael D. Elder CLA 2006-04-07 11:30:27 EDT

Can you also add the icon to the Java extension?

(There is an icon attribute on the org.eclipse.ui.navigator.navigatorContent extension for the Java contribution)

A suggested icon to use: icons/full/eview16/jperspective.gif

You can validate that the icon is being read correctly by taking a quick look at the "Available Extensions" tab in the "Available Customizations" dialog.
Comment 7 Markus Keller CLA 2006-04-07 13:17:32 EDT
Released the patch with a few changes:
- fixed editing leftover in plugin.xml
- changed icon as requested
- changed PackageExplorerActionProvider#TAG_LAYOUT to qualified string (users will lose their setting once, but that's not problem at this point in time)
- removed API change in OpenViewActionGroup in favor of a protected method that can be overridden by internmal clients. JDT/UI will discuss this problem again - maybe we should just remove the properties dialog action from this action group.
Comment 8 Tobias Widmer CLA 2006-04-26 12:43:59 EDT
Verified using N20060426-0010