Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 134892

Summary:	[DataBinding] Serious Concern Over Test Structure / Lack of Tests
Product:	[Eclipse Project] Platform	Reporter:	Scott Delap <scott>
Component:	UI	Assignee:	Boris Bokowski <bokowski>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	bradleyjames
Version:	3.2	Keywords:	helpwanted
Target Milestone:	3.3 M6
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Scott Delap

2006-04-04 17:37:53 EDT

I have serious concerns about the test coverage and structure of JFace Data Binding.  There are numerous classes which don't have a direct test.  I have submitted a number of patches recently that I would have created a test for.  However upon inspection no test exists for the class to start with.  Unfortunately I don't have time to write a test for the complete class and then address my own changes.  As more developers come onto the project I think they will have similar experiences.  

On a related note many of the tests are written based on scenarios instead of per class.  While I'll agree that some integration level tests are needed due to the nature of the project, most tests should probably be at the class level.  Unless I'm intimately familiar with what each scenario covers it is hard to know where to start.  In comparison a test for DataBindingContext means test all of DataBindingContext (within reason of course).

Comment 1 Boris Bokowski

2006-04-07 11:47:54 EDT

Unfortunately, I don't have any cycles right now to write more tests.  I do agree that having proper unit tests would be a good thing.

Comment 2 Brad Reynolds

2007-02-28 20:31:05 EST

I'm not sure how to qualify if this bug should be closed but as of today, 20070228, there are 377 tests for JFace Data Binding.  The majority of these are not scenarios and are per class to assert the abilities of each individually.  I'm a bit of a test junky and every fix/enhancement that I've made has been accompanied with numerous tests of new and existing functionality.

I'm closing this bug as I don't think that the concerns should be "serious" any longer.  We could always use more tests and more are being written every day.  But I think we're in a much better position than we were a year ago.

If either of you feel that this should be reopened feel free.  But if there are specific concerns I'd prefer to see a bug per class/concern.  We can then determine how to get the needed coverage.

FIXED > 20070228.

Comment 3 Kim Horne

2007-03-23 08:38:04 EDT

Marking as verified in I20070322-1800(with 420 tests).