Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 133561

Summary:	[Help] Incompatibility between Eclipse Help Tomcat & TPTP Apache commons-logging
Product:	[Eclipse Project] Platform	Reporter:	Ruth Lee <ruthdaly>
Component:	User Assistance	Assignee:	platform-ua-inbox <platform-ua-inbox>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	critical
Priority:	P3	CC:	paulslau, srinivas.p.doddapaneni
Version:	3.2
Target Milestone:	---
Hardware:	PC
OS:	Windows 2000
Whiteboard:
Bug Depends on:
Bug Blocks:	132184

Description Ruth Lee

2006-03-28 10:38:08 EST

The org.eclipse.tomcat plug-in ships a partial copy of Apache commons-logging version 1.0.3. TPTP ships a full copy of commons logging version 1.0.3 as well as a copy of Apache Log4J. When the Tomcat copy of commons logging is loaded before the TPTP version, the Help Contents dialog cannot be launched. (See bugzilla #132184 for details.)

This bugzilla is to separate the commons-logging that Tomcat ships into a separate plug-in, and to add the implementation code of commons-logging to that separate plug-in as well. I know that the Tomcat code should not be alterered due to licensing laws, but it should be possible to ship it in two plug-ins instead of one. 

Bugzilla 132184 should be used by TPTP to remove the TPTP copy of commons-logging and to add a dependency on the Help copy of commons-logging instead. 

Note that I am not an expert on any of this Apache code, and if the Help team decides with the TPTP Logging team that there's a better way to solve this problem, then that works for me too. Paul Slauenwhite (cc-ed) is the TPTP person who arranged for the Apache logging plug-ins in TPTP.

Comment 1 Curtis d'Entremont

2006-03-28 10:54:28 EST

This problem has already been fixed (after M5a). It was caused by the addition of a global buddy loading policy to the tomcat plugin. As a result, tomcat was trying to use the TPTP common logging and failing. This has already been removed and the problem should no longer exist.

There is no need to split the tomcat plugin; tomcat is just an implementation detail of the help system and you shouldn't be relying on any part of it. In fact there is a chance we will eventually stop using and shipping tomcat altogether in favor of the OSGi HTTP service.

*** This bug has been marked as a duplicate of 132020 ***

Comment 2 Paul Slauenwhite

2009-06-30 09:57:03 EDT

As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.

Comment 3 Paul Slauenwhite

2009-06-30 10:51:03 EDT

This enhancement/defect was mistaken closed as part of the TPTP 4.6 Bugzilla
housecleaning process (see
http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes) since the originator
of this enhancement/defect has an inactive Bugzilla account.  If this
enhancement/defect is still unresolved and reproducible, please re-open.