Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 133342

Summary:	[Commands] handlers: Global keybindings don't work (Open Type, Search, ...)
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Douglas Pollock <douglas.pollock>
Status:	VERIFIED FIXED	QA Contact:
Severity:	blocker
Priority:	P1	CC:	cocoakevin, daniel_megert, john.arthorne, Michael_Rennie, pwebster
Version:	3.2
Target Milestone:	3.2 M6
Hardware:	All
OS:	All
Whiteboard:

Description Markus Keller

2006-03-27 07:14:49 EST

I20060327-0010

Several important keybindings don't work in this build, although their menu items are enabled and show a shortcut:

- Open Type (Ctrl+SHift+T)
- Open Type Hierarchy
- Search (Ctrl+H)
- Organize Imports (in Package Explorer)

Comment 1 Markus Keller

2006-03-27 10:06:39 EST

Debug keybindings (F5-F8, Ctrl+Shift+D, Ctrl+Shift+I) also don't work.

Comment 2 John Arthorne

2006-03-27 14:48:01 EST

(same on I20060327-1200)

Comment 3 Douglas Pollock

2006-03-27 14:53:17 EST

What is the latest build that everything still worked?  I wasn't committing any code last week.  If the problem was introduced in the last week, this will significantly narrow my search.

(Reproduced on Linux GTK+)

Paul: There is no handler.  I'm going to keep digging, but my initial thoughts are LegacyActionPersistence.

Comment 4 Paul Webster

2006-03-27 15:17:06 EST

It worked fine in I20060322-1335.

PW

Comment 5 Douglas Pollock

2006-03-27 15:17:34 EST

Okay, tracked it down.  No handlers are read by the workbench.  The commit causing the problem is revision 1.339 of WorkbenchWindow.  The LegacyActionPersistence.read() call was put inside a block that is not hit by default.

The workaround is to set the org.eclipse.ui/experimental/menus option on start-up.  Though this will probably destroy your top-level menus.

I have reverted the change, and it seems to work for me.  I'll run the tests and then commit.

Comment 6 Douglas Pollock

2006-03-27 15:38:01 EST

Okay, the tests all pass.  Committing change.

Comment 7 Dani Megert

2006-03-28 04:07:14 EST

Verified using I20060328-0010.