| Summary: | [j2ee] J2EEPlugin must use an ImageRegistry | ||
|---|---|---|---|
| Product: | [WebTools] WTP Java EE Tools | Reporter: | Chris Laffra <laffrac> |
| Component: | jst.j2ee | Assignee: | Salvador Zalapa <zalapa> |
| Status: | RESOLVED FIXED | QA Contact: | Chuck Bridgham <cbridgha> |
| Severity: | major | ||
| Priority: | P2 | CC: | cbridgha, ccc |
| Version: | unspecified | Keywords: | helpwanted |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
|
Description
Chris Laffra
I also noticed this editor is leaking 6 handles. Sleak should be run on it, after the ImageRegistry is added to ensure no leaks occur. After the editor is opened, I click on each tab and see lots of images opened for again. For instance, after clicking on all tabs I saw these: eclipse\plugins\org.eclipse.jst.j2ee.web_1.0.0.v20060202_1038.jar:icons/servlet_mapping.gif open counter = 192 [i.e., this gif is opened 192 times] eclipse\plugins\org.eclipse.jst.j2ee.web_1.0.0.v20060202_1038.jar:icons/full/obj16/servlet.gif open counter = 131 eclipse\plugins\org.eclipse.jst.j2ee_1.0.0.v200602201944.jar:icons/full/obj16/listener.gif open counter = 66 eclipse\plugins\com.ibm.etools.webtools.flatui_6.0.0.jar:icons/form_banner.gif open counter = 61 eclipse\plugins\org.eclipse.ui.views_3.2.0.I20051129-0800.jar:icons/full/elcl16/defaults_ps.gif open counter = 2 Adding an ImageRegistry will also help out org.eclipse.jst.j2ee.navigator.internal.J2EELabelProvider.getImage(J2EELabelProvider.java:150) which relies on J2EEPlugin also. During a workspace build, label images are also repeatedly opened. performance bugs should use performance keyword (not [performance] in subject). This could become an IBM adopter hot bug. Doesn't qualify for hotbug status... but we are comitted to fixing in 153 Deferring to 2.0 for further investigatiom, J2EEPlugin is non UI but it contains images, introducing ImageRegistry causes it to throw NPE in headless mode since ImageRegistry needs a valid SWT Display. This was fixed by EMF - AdapterFactoryLabelProvider now uses an ImageRegistry which is keyed off of the URL that is provided by J2EEPlugin.getImage(). As such, I assume that this leakage has been reduced. If there is still data indicating that there is a leak, please reopen this bug and present that data. |