Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 131377

Summary: Related to bug 131373, the build script should set up the log file name inside a compiler argument
Product: [Eclipse Project] PDE Reporter: Olivier Thomann <Olivier_Thomann>
Component: BuildAssignee: pde-build-inbox <pde-build-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: veronika_irvine
Version: 3.2   
Target Milestone: 3.2 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 131394    
Attachments:
Description Flags
Proposed fix
none
New patch
none
Last patch
none
patch for org.eclipse.swt.win32.win32.x86 none

Description Olivier Thomann CLA 2006-03-10 14:08:17 EST 
The build script should set up the log file name using a compilerarg nested element in the javac ant task instead of using the verbose mode.
See bug 131373.
The corresponding compilerarg nested element should set up its compiler name in order to prevent javac from being called with this option that it doesn't support.
Doing this would remove a hack from the ant adapter.
We need to synchronize our changes.
Veronika, you would need to update all custom builds.
Comment 1 Olivier Thomann CLA 2006-03-10 14:53:58 EST 
Created attachment 36077 [details]
Proposed fix
Comment 2 Olivier Thomann CLA 2006-03-10 15:24:38 EST 
Created attachment 36082 [details]
New patch

I tested it on jdt.core
Comment 3 Olivier Thomann CLA 2006-03-10 15:45:15 EST 
Created attachment 36083 [details]
Last patch

The previous patch would not set the log file if no compiler args were required.
This is fixed now.
Comment 4 Pascal Rapicault CLA 2006-03-10 16:25:19 EST 
Patch released in HEAD.
Comment 5 Veronika Irvine CLA 2006-03-13 10:00:00 EST 
What do I need to change in the SWT custom scripts?
Comment 6 Veronika Irvine CLA 2006-03-13 10:56:49 EST 
Created attachment 36149 [details]
patch for org.eclipse.swt.win32.win32.x86

I have attatched a patch for the changes required to the SWT windows fragment.  A similar patch must be created for all SWT fragments.  Note: the build.xml for org.eclipse.swt does not call javac so it does not need to change.
Comment 7 DJ Houghton CLA 2006-04-18 16:06:14 EDT 
[contributed patch applied]