Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 130721

Summary:	Refactor and expose SetValueCommand
Product:	[Tools] GEF	Reporter:	Robert Stephan <roste>
Component:	GEF-Legacy GEF (MVC)	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	nyssen
Version:	unspecified
Target Milestone:	3.7.1 (Indigo) M6
Hardware:	All
OS:	All
Whiteboard:

Description Robert Stephan

2006-03-07 05:53:05 EST

In my GEF application I create a Log-File, that is based on CommandStackEvents. To read the information stored in org.eclipse.gef.ui.properties.SetValueCommand after property changes, the class SetValueCommand needs to be accessable by public.

In an other part of my application I would like to create a SetValueCommand object "manually". Therefore it would be nice to have additional public setter and getter methods for the undoValue.

Thanks

Robert Stephan

Comment 1 Alexander Nyßen

2011-03-09 17:01:04 EST

SetValueCommand and ResetValueCommand need refactoring before exposing them. Actually, ResetValueCommand is not needed if SetValueCommand handles this as well. Changed summary to indicate this.

Comment 2 Alexander Nyßen

2011-03-09 17:04:43 EST

Refactored SetValueCommand and ResetValueCommand into a single SetPropertyValueComand, which can as well be used to reset a property value (in case it has a value different from its default value). Exposed SetPropertyValueCommand as public. Removed message entries used for ResetValueCommand.

Changes committed to cvs HEAD (3.7M6). Resolving as fixed.