Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 129709

Summary:

[relengtool] Load Map Projects functionality sets version tag for "HEAD"

Product:

[Eclipse Project] Platform

Reporter:

Sebastian Schaer <sschaer>

Component:

Releng

Assignee:

Allan Godding <Allan_Godding>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

dj.houghton, Michael.Valenta, sonia_dimitrov

Version:

3.1.2

Keywords:

helpwanted

Target Milestone:

---

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
fixes the bug by explicitly checking for HEAD string in map entry	none
Patch for relengtools	none
new patch	none

Description Sebastian Schaer

2006-02-27 22:21:39 EST

When loading projects into the workspace from a map file, an entry such as 

plugin@com.ibm.example=HEAD,:pserver:example.ibm.com:/cvsroot,,plugins/com.ibm.example

gets loaded with an explicit HEAD tag (as a Version tag instead of as the main branch). It shows "HEAD" as decoration in the package explorer and the properties of the plugin show "HEAD (Version)".

After that, changes made to the plugin cannot be commited. The cvs repository complains that the version or branch "HEAD" does not exist.

Right now a manual "switch to another branch or version" is needed to remove that version tag "HEAD".

I can provide a quick solution for it by modifying the 
org.eclipse.releng.tools.MapEntry.init() so that in case of a tagName "HEAD" it just changes it to "".
(This works for me.. I could provide a patch if desired)

Comment 1 Sebastian Schaer

2006-03-20 01:06:24 EST

Created attachment 36583 [details]
fixes the bug by explicitly checking for HEAD string in map entry

fixes the bug by explicitly checking for HEAD string in map entry.

Comment 2 Sebastian Schaer

2006-03-20 01:07:28 EST

fixed by supplying the patch

Comment 3 Sonia Dimitrov

2006-03-23 11:24:52 EST

Re-opening to review patch. 

We don't consider a bug fixed if we haven't actually applied the patch and released the change : )

Comment 4 DJ Houghton

2007-09-13 12:09:23 EDT

Allan, please review. Thanks.

Comment 5 Allan Godding

2007-09-14 16:22:58 EDT

Created attachment 78467 [details]
Patch for relengtools

Sets the SVC tag to an empty string for MapEntry objects which are located in HEAD.

Comment 6 DJ Houghton

2007-09-14 16:57:34 EDT

Created attachment 78476 [details]
new patch

Patch looks good. Here is an update with minor changes. We moved the "is HEAD branch" check to #getTagName because there are other methods which rely on the value being the "HEAD" string.

Sonia please release. Thanks.

Comment 7 Sonia Dimitrov

2007-09-17 09:22:59 EDT

Thanks guys, patch applied and released for the next 3.4 stream build.