Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 129554

Summary:	[preferences] Edit Template: Rename Yes/No buttons and dialog text
Product:	[Eclipse Project] Platform	Reporter:	Marcus Sundman <sundman>
Component:	Text	Assignee:	Gautier de SAINT MARTIN LACAZE <gautier.desaintmartinlacaze>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P5	CC:	akurtakov, gautier.desaintmartinlacaze, Lars.Vogel, markus.kell.r
Version:	3.2
Target Milestone:	4.15 M3
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/157559 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=5212f4dfaf0e391904b31c5d9da2bb2656bfb332
Whiteboard:	Helpwanted, usability
Bug Depends on:
Bug Blocks:	553537

Description Marcus Sundman

2006-02-27 07:22:11 EST

The Edit Template dialog box is a textbook example of bad options. It says:

"The name of the template has been changed. Click 'Yes' to create an additional template with the new name or 'No' to rename the existing one."
Options: Yes/No

If 2/3 of the description is explanations what the options are supposed to be it's quite obvious that the options are bad. I suggest relabeling 'Yes' -> 'Create new' and 'No' -> 'Rename existing'.

This is one of the first dialogs I've seen in Eclipse, so I suppose there are a lot more like this. In general it's better to avoid Yes/No options, because they almost always require the user to spend unnecessarily much time and effort in understanding the exact wording of the question. Instead the action should be more or less obvious based on the options. (E.g. instead of "Do you want to quit without saving? Options: Yes/No" or "Do you want to save before you quit? Options: Yes/No" you should always prefer something like "There are modifications. Options: Save and quit/Discard and quit".)

Comment 1 Dani Megert

2006-02-27 09:23:58 EST

This dialog shouldn't appear in the first place: either we should silently rename the template or not allow to change the name.

Whether to use 'Yes', 'OK' and 'No' or put the concrete action itself onto the button is a style question. Currently most Eclipse confirm dialogs follow the 'Yes'/'No' pattern. If you think another dialog is wrong you'll have to file a concrete bug for that dialog.

Comment 2 Markus Keller

2015-11-02 06:39:35 EST

(In reply to Dani Megert from comment #1)
> This dialog shouldn't appear in the first place: either we should silently
> rename the template or not allow to change the name.

Nope, both of these options would remove important functionality.

We either need a "Duplicate..." button (then we can get rid of the dialog), or the buttons should be renamed to "Rename Existing" and "Create New".

Comment 3 Eclipse Genie

2019-11-03 00:42:48 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 4 Eclipse Genie

2020-02-12 05:50:21 EST

New Gerrit change created: https://git.eclipse.org/r/157559

Comment 5 Eclipse Genie

2020-02-12 10:56:55 EST

Gerrit change https://git.eclipse.org/r/157559 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=5212f4dfaf0e391904b31c5d9da2bb2656bfb332

Comment 6 Alexander Kurtakov

2020-02-12 10:58:25 EST

Thanks Gautier! It's a pleasure to see such long standing UX issues being taken care of.

Comment 7 Gautier de SAINT MARTIN LACAZE

2020-02-12 12:05:00 EST

No problem. If you can point me on other issue like this one, I will be glad to have a look.

Comment 8 Lars Vogel

2020-02-13 07:41:04 EST

(In reply to Gautier de SAINT MARTIN LACAZE from comment #7)
> No problem. If you can point me on other issue like this one, I will be glad
> to have a look.

Thank you also from my side. 
Bug 538043 is similar, you can also have a look in Bug 553537 in which I try to capture such issues.