Bugzilla – Full Text Bug Listing
| Summary: | [FastView] Problem occurs when "weclome" view be put into "Fast View" bar | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | James Gan <ganzhi> | ||||||
| Component: | UI | Assignee: | Eric Moffatt <emoffatt> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | eclipse, fuse, Mike_Wilson, pwebster | ||||||
| Version: | 3.2 | Flags: | eclipse:
review+
pwebster: review+ |
||||||
| Target Milestone: | 3.3 RC2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
James Gan
Over to me...;-). Does this still happen? Please mark as fixed or update milestone appropriately. Yes, this is still an issue (thanks for the pickup. I'll mark this for RC1 and take a look (but, IMO, this is not a 'stop ship' defect since the workflow is most uncommon). BTW, just checked and thos behavior has been there since 3.1... Created attachment 66688 [details]
Partial fix for this defect
This patch will stop the 'could not create...' failure dialog from coming up and correctly instantiates the intro view as either a FastView or in its minimized stack (which had the same issue).
However, the Welcome shows up as the active view on a restart (caused by 'createView' assuming that the newly created view should always be activated.
We could claim that this is a feature...;-).
*** Bug 63385 has been marked as a duplicate of this bug. *** Moving to RC2... Created attachment 68344 [details]
Cleaner patch using the new 'getViewReference' method in Perspective
You'll need the version of Perspective from HEAD to apply this patch successfully (since I reference a new method).
Note that this patch still has the Intro view coming up (as a fast view) on a restart...this is the result of the WorkbenchIntroManager#createIntro method calling 'workbenchPage.showView(IIntroConstants.INTRO_VIEW_ID)' as part of the restore handling if the Intro was 'visible' on shutdown. I've tried the 'obvious' fix of testing to see if the view is a fast view before calling showview but that ended up with the wrong icon and an empty intro view. I think we should accept the patch (if acceptable...;-) and open a 3.4 defect against the remaining oddity. Kim, could you take a look at this one (any hints on how not to get the FV to open)? Paul, eyes #2 again? I'm happy with the lack of exception for 3.3. I'm not sure how to go the full 9 yards on this one... Committed in >20070523. Verified in I20070524-0010. |